Create net::FormatOriginForDisplay helper function

net/base/net_util.h

Index: net/base/net_util.h
diff --git a/net/base/net_util.h b/net/base/net_util.h
index c74dfd2ea48486b08e16be9fdb700b9d99f06bd0..5a3ce7aacf4b3cff78c85aab2c6b2e109574a56a 100644
--- a/net/base/net_util.h
+++ b/net/base/net_util.h
@@ -74,6 +74,14 @@ NET_EXPORT extern const FormatUrlType kFormatUrlOmitTrailingSlashOnBareHostname;
 // Convenience for omitting all unecessary types.
 NET_EXPORT extern const FormatUrlType kFormatUrlOmitAll;
 
+// Remove the scheme.  The caller should only specify kFormatUrlOmitScheme
+// after verifying that it is secure to do so. Not part of kFormatUrlOmitAll.
+NET_EXPORT extern const FormatUrlType kFormatUrlOmitScheme;
+
+// Remove the port.  The caller should only specify kFormatUrlOmitPort
+// after verifying that it is secure to do so. Not part of kFormatUrlOmitAll.

[Ryan Sleevi, 2014/09/02 19:26:17]

This is... vaguely worded.

When is it ever secure to omit the port? Only when the port is a default port,
correct?

+NET_EXPORT extern const FormatUrlType kFormatUrlOmitPort;
+
 // Returns the number of explicitly allowed ports; for testing.
 NET_EXPORT_PRIVATE extern size_t GetCountOfExplicitlyAllowedPorts();
 
@@ -338,6 +346,17 @@ inline base::string16 FormatUrl(const GURL& url, const std::string& languages) {
                    NULL, NULL, NULL);
 }
 
+// This is a convenience function for formatting a URL as an origin for display
+// in security UI: infobars, permission strings, etc. Use this instead of

[Ryan Sleevi, 2014/09/02 19:26:17]

So, to re-iterate the layering, //net has no idea about (infobars, permission
strings, etc). It's a conceptual separation in //net (that occasionally gets
punctured, and then I whine about it until someone fixes it or tries to do more
of the same, and then I whine until either they fix it or they call me on my
whining and I fix it)

Strictly from a code layout and layering point, what code potentially calls into
this? Is it //content? //chrome? //components? I would rather explore that, and
understand how the high level code would/is going to use this, and then figure
out the right layer.

Ideal world, this would live in //chrome/browser/ui, and just call FormatUrl
with some set of flags.

[felt, 2014/09/15 05:42:30]

Here are some files that should be refactored to call this proposed new method:
//chrome/browser/pepper_broker_infobar_delegate.cc
//chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.cc
//chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
//chrome/browser/content_settings/permission_infobar_delegate.cc

And possibly also these:
//components/nacl/browser/nacl_process_host.cc
//content/browser/frame_host/navigation_entry_impl.cc

For the first few, c/b/ui seems appropriate, but that wouldn't work for the
//components and //content code. WDYT?

[felt, 2014/09/15 22:47:55]

Sleevi: what about putting this on gurl.h?

+// FormatUrl() for strings in a security UI context. Do not use this for URLs
+// which will be parsed or sent to other applications.
+// - The path is dropped for standard schemes, excepting file and filesystem.
+// - Standard ports are removed for http and https.
+// - By default, the scheme is only displayed for non-secure origins. This can

[Michael van Ouwerkerk, 2014/09/02 13:10:47]

Why is https omitted by default? Haven't we been teaching users for years to
specifically look for https to check it's safe?

+//   be overridden with |always_show_scheme|.
+NET_EXPORT base::string16 FormatOriginForDisplay(
+    const GURL& origin, const std::string& languages, bool always_show_scheme);
+
 // Returns whether FormatUrl() would strip a trailing slash from |url|, given a
 // format flag including kFormatUrlOmitTrailingSlashOnBareHostname.
 NET_EXPORT bool CanStripTrailingSlash(const GURL& url);