Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Side by Side Diff: Source/core/rendering/RenderTableSection.h

Issue 532513002: Don't use rowIndex() if needsCellRecalc(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: NULL check in assertion, to avoid crash in unit tests. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderTableRow.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights reserv ed. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights reserv ed.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 { 199 {
200 if (m_needsCellRecalc) 200 if (m_needsCellRecalc)
201 recalcCells(); 201 recalcCells();
202 } 202 }
203 203
204 bool needsCellRecalc() const { return m_needsCellRecalc; } 204 bool needsCellRecalc() const { return m_needsCellRecalc; }
205 void setNeedsCellRecalc(); 205 void setNeedsCellRecalc();
206 206
207 LayoutUnit rowBaseline(unsigned row) { return m_grid[row].baseline; } 207 LayoutUnit rowBaseline(unsigned row) { return m_grid[row].baseline; }
208 208
209 void rowLogicalHeightChanged(unsigned rowIndex); 209 void rowLogicalHeightChanged(RenderTableRow*);
210 210
211 void removeCachedCollapsedBorders(const RenderTableCell*); 211 void removeCachedCollapsedBorders(const RenderTableCell*);
212 void setCachedCollapsedBorder(const RenderTableCell*, CollapsedBorderSide, C ollapsedBorderValue); 212 void setCachedCollapsedBorder(const RenderTableCell*, CollapsedBorderSide, C ollapsedBorderValue);
213 CollapsedBorderValue& cachedCollapsedBorder(const RenderTableCell*, Collapse dBorderSide); 213 CollapsedBorderValue& cachedCollapsedBorder(const RenderTableCell*, Collapse dBorderSide);
214 214
215 // distributeExtraLogicalHeightToRows methods return the *consumed* extra lo gical height. 215 // distributeExtraLogicalHeightToRows methods return the *consumed* extra lo gical height.
216 // FIXME: We may want to introduce a structure holding the in-flux layout in formation. 216 // FIXME: We may want to introduce a structure holding the in-flux layout in formation.
217 int distributeExtraLogicalHeightToRows(int extraLogicalHeight); 217 int distributeExtraLogicalHeightToRows(int extraLogicalHeight);
218 218
219 static RenderTableSection* createAnonymousWithParentRenderer(const RenderObj ect*); 219 static RenderTableSection* createAnonymousWithParentRenderer(const RenderObj ect*);
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 static const bool needsDestruction = false; 326 static const bool needsDestruction = false;
327 }; 327 };
328 template<> struct VectorTraits<blink::RenderTableSection::RowStruct> : VectorTra itsBase<blink::RenderTableSection::RowStruct> { 328 template<> struct VectorTraits<blink::RenderTableSection::RowStruct> : VectorTra itsBase<blink::RenderTableSection::RowStruct> {
329 static const bool needsDestruction = false; 329 static const bool needsDestruction = false;
330 }; 330 };
331 #endif 331 #endif
332 332
333 } 333 }
334 334
335 #endif // RenderTableSection_h 335 #endif // RenderTableSection_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTableRow.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698