Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 532473002: InterfaceDescriptor becomes CallInterfaceDescriptor. (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

InterfaceDescriptor becomes CallInterfaceDescriptor. There was no difference between these two classes in a hierarchical relationship. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23560

Patch Set 1 #

Patch Set 2 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -91 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.h View 1 2 chunks +6 lines, -7 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-arm64.h View 1 2 chunks +6 lines, -7 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +11 lines, -16 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 4 chunks +15 lines, -27 lines 0 comments Download
M src/interface-descriptors.cc View 6 chunks +6 lines, -18 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
Refactoring continued! Uploading ports... --Michael
6 years, 3 months ago (2014-09-01 09:42:15 UTC) #1
Yang
On 2014/09/01 09:42:15, mvstanton wrote: > Refactoring continued! Uploading ports... > --Michael looking good. waiting ...
6 years, 3 months ago (2014-09-01 09:45:54 UTC) #2
mvstanton
Right on, they are there. --Michael
6 years, 3 months ago (2014-09-01 09:51:56 UTC) #3
Yang
lgtm.
6 years, 3 months ago (2014-09-01 11:48:26 UTC) #4
mvstanton
6 years, 3 months ago (2014-09-01 12:15:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23560 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698