Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 532423003: Add the "testonly" flag to the GN test target. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@pullgn
Project:
chromium
Visibility:
Public.

Description

Add the "testonly" flag to the GN test target. Now that the new GN has landed with support for this, we can start using this flag. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/6643d00237eff7a9d1de2ac771f861f61785f6fb

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : merge #

Patch Set 4 : android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M build/config/BUILDCONFIG.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M mojo/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
brettw
6 years, 3 months ago (2014-09-03 22:16:56 UTC) #2
viettrungluu
lgtm
6 years, 3 months ago (2014-09-03 22:19:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/532423003/20001
6 years, 3 months ago (2014-09-05 05:26:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/51987) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/56833) linux_chromium_gn_rel ...
6 years, 3 months ago (2014-09-05 05:33:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/532423003/40001
6 years, 3 months ago (2014-09-05 18:31:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/12809)
6 years, 3 months ago (2014-09-05 18:41:24 UTC) #11
brettw
Committed patchset #4 (id:60001) manually as 6643d00 (presubmit successful).
6 years, 3 months ago (2014-09-05 21:14:24 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:31 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6643d00237eff7a9d1de2ac771f861f61785f6fb
Cr-Commit-Position: refs/heads/master@{#293579}

Powered by Google App Engine
This is Rietveld 408576698