Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: pkg/analysis_server/test/analysis/get_errors_test.dart

Issue 532403002: Fix error handling in analysis.getError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis/get_errors_test.dart
diff --git a/pkg/analysis_server/test/analysis/get_errors_test.dart b/pkg/analysis_server/test/analysis/get_errors_test.dart
index 3259634e7cbc9296868efe5add758dd5c10c493a..43d2219cfdf0bbf6b67bc6c8aed5494531cb3ed9 100644
--- a/pkg/analysis_server/test/analysis/get_errors_test.dart
+++ b/pkg/analysis_server/test/analysis/get_errors_test.dart
@@ -47,9 +47,7 @@ main() {
test_fileDoesNotExist() {
String file = '$projectPath/doesNotExist.dart';
- return _getErrors(file).then((List<AnalysisError> errors) {
- expect(errors, isEmpty);
- });
+ return _checkInvalid(file);
}
test_fileWithoutContext() {
@@ -59,9 +57,7 @@ main() {
print(42);
}
''');
- return _getErrors(file).then((List<AnalysisError> errors) {
- expect(errors, isEmpty);
- });
+ return _checkInvalid(file);
}
test_hasErrors() {
@@ -102,18 +98,15 @@ main() {
// handle the request synchronously
Request request = _createGetErrorsRequest();
server.handleRequest(request);
- // remove context, causes sending a 'cancelled' error
+ // remove context, causes sending an "invalid file" error
{
Folder projectFolder = resourceProvider.getResource(projectPath);
server.contextDirectoryManager.removeContext(projectFolder);
}
// wait for an error response
return serverChannel.waitForResponse(request).then((Response response) {
- var result = new AnalysisGetErrorsResult.fromResponse(response);
- expect(result.errors, isEmpty);
- RequestError error = response.error;
- expect(error, isNotNull);
- expect(error.code, RequestErrorCode.GET_ERRORS_ERROR);
+ expect(response.error, isNotNull);
+ expect(response.error.code, RequestErrorCode.GET_ERRORS_INVALID_FILE);
});
}
@@ -127,4 +120,12 @@ main() {
return new AnalysisGetErrorsResult.fromResponse(response).errors;
});
}
+
+ Future _checkInvalid(String file) {
+ Request request = _createGetErrorsRequest();
+ return serverChannel.sendRequest(request).then((Response response) {
+ expect(response.error, isNotNull);
+ expect(response.error.code, RequestErrorCode.GET_ERRORS_INVALID_FILE);
+ });
+ }
}

Powered by Google App Engine
This is Rietveld 408576698