pkg/analysis_server/lib/src/operation/operation_analysis.dart - Issue 532403002: Fix error handling in analysis.getError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 532403002: Fix error handling in analysis.getError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart

diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart

index 8dea71d971d0f06757975e8c99c27da0bca96123..11cb226d7200e7b19bc98e96aadecad9f323b673 100644

--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart

+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart

@@ -95,7 +95,8 @@ class PerformAnalysisOperation extends ServerOperation {

AnalysisResult result = context.performAnalysisTask();

List<ChangeNotice> notices = result.changeNotices;

if (notices == null) {

- server.sendContextAnalysisDoneNotifications(context);

+ server.sendContextAnalysisDoneNotifications(context,

+ AnalysisDoneReason.COMPLETE);

return;

}

// process results