Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 532343002: Progress HTMLDocumentParser state on non-interrupted cases (Closed)

Created:
6 years, 3 months ago by kouhei (in TOK)
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Progress HTMLDocumentParser state on non-interrupted cases Before this patch, HTMLDocumentParser never progressed to StoppedState but stuck in StoppingState when parsing finished without being interrupted. This patch adds a call to |DocumentParser::stopParsing()| to ensure its |m_state| progress to StoppedState. BUG=409461 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kouhei (in TOK)
Would you take a look?
6 years, 3 months ago (2014-09-03 20:17:33 UTC) #2
eseidel
What state did it get stuck in? Otherwise seems reasonable to me. lgtm.
6 years, 3 months ago (2014-09-03 22:30:16 UTC) #3
kouhei (in TOK)
On 2014/09/03 22:30:16, eseidel wrote: > What state did it get stuck in? > > ...
6 years, 3 months ago (2014-09-03 22:31:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/532343002/1
6 years, 3 months ago (2014-09-03 22:32:02 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 22:35:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181346

Powered by Google App Engine
This is Rietveld 408576698