Have build/landmines.py delete contents of build directory.

Have build/landmines.py delete contents of build directory.

Some checkouts have the build directory mounted, which causes the script
to throw an exception when it attempts to remove the directory itself.

Committed: https://crrev.com/bb04e1054366543cb554531c728b33525a5dae8c
Cr-Commit-Position: refs/heads/master@{#293199}

[scherkus (not reviewing), 2014-09-03 17:36:01]

scherkus@chromium.org changed reviewers:
+ scottmg@chromium.org

[scherkus (not reviewing), 2014-09-03 17:36:02]

scottmg: looks like you've touched this

also ... any thoughts? can I test this somehow?

[scottmg, 2014-09-03 17:45:48]

lgtm

[scherkus (not reviewing), 2014-09-03 18:08:05]

The CQ bit was checked by scherkus@chromium.org

[commit-bot: I haz the power, 2014-09-03 18:08:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scherkus@chromium.org/532323002/1

[commit-bot: I haz the power, 2014-09-03 21:30:02]

Committed patchset #1 (id:1) as 9cf094bb9cc955a6315289afb2f965cc9c36cfc9

[scottmg, 2014-09-04 16:29:02]

Hm, I'm not sure if it's related to this or not, but clobber is failing for me
this morning

I assume os.listdir just walks the dir, but maybe it's doing something wacky...
or ... hmm.

d:\src\cr3\src>gclient sync
Syncing projects: 100% (133/133), done.

________ running 'd:\src\depot_tools\python276_bin\python.exe
src/build/landmines.py' in 'd:\src\cr3'
Clobbering due to:
--- old_landmines       Thu Aug 14 14:23:08 2014
+++ new_landmines       Thu Sep 04 09:21:37 2014
@@ -11,0 +12 @@
+ninja dependency cycle: crbug.com/408192
Traceback (most recent call last):
  File "src/build/landmines.py", line 137, in <module>
    sys.exit(main())
  File "src/build/landmines.py", line 131, in main
    clobber_if_necessary(landmines)
  File "src/build/landmines.py", line 81, in clobber_if_necessary
    shutil.rmtree(path)
  File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 256, in rmtree
    onerror(os.rmdir, path, sys.exc_info())
  File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 254, in rmtree
    os.rmdir(path)
WindowsError: [Error 145] The directory is not empty:
'd:\\src\\cr3\\src\\out\\Release_x64\\gen\\content\\app'
Error: Command d:\src\depot_tools\python276_bin\python.exe
src/build/landmines.py returned non-zero exit status 1 in d:\src\cr3
Hook ''d:\src\depot_tools\python276_bin\python.exe' src/build/landmines.py' took
25.72 secs

[skia-font-refs]d:\src\cr3\src>gclient sync
Syncing projects: 100% (133/133), done.

________ running 'd:\src\depot_tools\python276_bin\python.exe
src/build/landmines.py' in 'd:\src\cr3'
Clobbering due to:
--- old_landmines       Thu Aug 14 14:23:08 2014
+++ new_landmines       Thu Sep 04 09:22:44 2014
@@ -11,0 +12 @@
+ninja dependency cycle: crbug.com/408192
Traceback (most recent call last):
  File "src/build/landmines.py", line 137, in <module>
    sys.exit(main())
  File "src/build/landmines.py", line 131, in main
    clobber_if_necessary(landmines)
  File "src/build/landmines.py", line 81, in clobber_if_necessary
    shutil.rmtree(path)
  File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
    rmtree(fullname, ignore_errors, onerror)
  File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 256, in rmtree
    onerror(os.rmdir, path, sys.exc_info())
  File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 254, in rmtree
    os.rmdir(path)
WindowsError: [Error 145] The directory is not empty:
'd:\\src\\cr3\\src\\out\\Release_x64\\gen\\device\\bluetooth'
Error: Command d:\src\depot_tools\python276_bin\python.exe
src/build/landmines.py returned non-zero exit status 1 in d:\src\cr3

[scottmg, 2014-09-04 16:36:57]

On 2014/09/04 16:29:02, scottmg wrote:
> Hm, I'm not sure if it's related to this or not, but clobber is failing for me
> this morning
> 
> I assume os.listdir just walks the dir, but maybe it's doing something
wacky...
> or ... hmm.
> 
> d:\src\cr3\src>gclient sync
> Syncing projects: 100% (133/133), done.
> 
> ________ running 'd:\src\depot_tools\python276_bin\python.exe
> src/build/landmines.py' in 'd:\src\cr3'
> Clobbering due to:
> --- old_landmines       Thu Aug 14 14:23:08 2014
> +++ new_landmines       Thu Sep 04 09:21:37 2014
> @@ -11,0 +12 @@
> +ninja dependency cycle: crbug.com/408192
> Traceback (most recent call last):
>   File "src/build/landmines.py", line 137, in <module>
>     sys.exit(main())
>   File "src/build/landmines.py", line 131, in main
>     clobber_if_necessary(landmines)
>   File "src/build/landmines.py", line 81, in clobber_if_necessary
>     shutil.rmtree(path)
>   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
>     rmtree(fullname, ignore_errors, onerror)
>   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
>     rmtree(fullname, ignore_errors, onerror)
>   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
>     rmtree(fullname, ignore_errors, onerror)
>   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 256, in rmtree
>     onerror(os.rmdir, path, sys.exc_info())
>   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 254, in rmtree
>     os.rmdir(path)
> WindowsError: [Error 145] The directory is not empty:
> 'd:\\src\\cr3\\src\\out\\Release_x64\\gen\\content\\app'
> Error: Command d:\src\depot_tools\python276_bin\python.exe
> src/build/landmines.py returned non-zero exit status 1 in d:\src\cr3
> Hook ''d:\src\depot_tools\python276_bin\python.exe' src/build/landmines.py'
took
> 25.72 secs
> 
> [skia-font-refs]d:\src\cr3\src>gclient sync
> Syncing projects: 100% (133/133), done.
> 
> ________ running 'd:\src\depot_tools\python276_bin\python.exe
> src/build/landmines.py' in 'd:\src\cr3'
> Clobbering due to:
> --- old_landmines       Thu Aug 14 14:23:08 2014
> +++ new_landmines       Thu Sep 04 09:22:44 2014
> @@ -11,0 +12 @@
> +ninja dependency cycle: crbug.com/408192
> Traceback (most recent call last):
>   File "src/build/landmines.py", line 137, in <module>
>     sys.exit(main())
>   File "src/build/landmines.py", line 131, in main
>     clobber_if_necessary(landmines)
>   File "src/build/landmines.py", line 81, in clobber_if_necessary
>     shutil.rmtree(path)
>   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
>     rmtree(fullname, ignore_errors, onerror)
>   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
>     rmtree(fullname, ignore_errors, onerror)
>   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
>     rmtree(fullname, ignore_errors, onerror)
>   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 256, in rmtree
>     onerror(os.rmdir, path, sys.exc_info())
>   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 254, in rmtree
>     os.rmdir(path)
> WindowsError: [Error 145] The directory is not empty:
> 'd:\\src\\cr3\\src\\out\\Release_x64\\gen\\device\\bluetooth'
> Error: Command d:\src\depot_tools\python276_bin\python.exe
> src/build/landmines.py returned non-zero exit status 1 in d:\src\cr3

Worked the third time. Maybe we need to have a customized rmtree for the
awesomeness of NTFS.

[scherkus (not reviewing), 2014-09-04 16:43:52]

On 2014/09/04 16:36:57, scottmg wrote:
> On 2014/09/04 16:29:02, scottmg wrote:
> > Hm, I'm not sure if it's related to this or not, but clobber is failing for
me
> > this morning
> > 
> > I assume os.listdir just walks the dir, but maybe it's doing something
> wacky...
> > or ... hmm.
> > 
> > d:\src\cr3\src>gclient sync
> > Syncing projects: 100% (133/133), done.
> > 
> > ________ running 'd:\src\depot_tools\python276_bin\python.exe
> > src/build/landmines.py' in 'd:\src\cr3'
> > Clobbering due to:
> > --- old_landmines       Thu Aug 14 14:23:08 2014
> > +++ new_landmines       Thu Sep 04 09:21:37 2014
> > @@ -11,0 +12 @@
> > +ninja dependency cycle: crbug.com/408192
> > Traceback (most recent call last):
> >   File "src/build/landmines.py", line 137, in <module>
> >     sys.exit(main())
> >   File "src/build/landmines.py", line 131, in main
> >     clobber_if_necessary(landmines)
> >   File "src/build/landmines.py", line 81, in clobber_if_necessary
> >     shutil.rmtree(path)
> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
> >     rmtree(fullname, ignore_errors, onerror)
> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
> >     rmtree(fullname, ignore_errors, onerror)
> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
> >     rmtree(fullname, ignore_errors, onerror)
> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 256, in rmtree
> >     onerror(os.rmdir, path, sys.exc_info())
> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 254, in rmtree
> >     os.rmdir(path)
> > WindowsError: [Error 145] The directory is not empty:
> > 'd:\\src\\cr3\\src\\out\\Release_x64\\gen\\content\\app'
> > Error: Command d:\src\depot_tools\python276_bin\python.exe
> > src/build/landmines.py returned non-zero exit status 1 in d:\src\cr3
> > Hook ''d:\src\depot_tools\python276_bin\python.exe' src/build/landmines.py'
> took
> > 25.72 secs
> > 
> > [skia-font-refs]d:\src\cr3\src>gclient sync
> > Syncing projects: 100% (133/133), done.
> > 
> > ________ running 'd:\src\depot_tools\python276_bin\python.exe
> > src/build/landmines.py' in 'd:\src\cr3'
> > Clobbering due to:
> > --- old_landmines       Thu Aug 14 14:23:08 2014
> > +++ new_landmines       Thu Sep 04 09:22:44 2014
> > @@ -11,0 +12 @@
> > +ninja dependency cycle: crbug.com/408192
> > Traceback (most recent call last):
> >   File "src/build/landmines.py", line 137, in <module>
> >     sys.exit(main())
> >   File "src/build/landmines.py", line 131, in main
> >     clobber_if_necessary(landmines)
> >   File "src/build/landmines.py", line 81, in clobber_if_necessary
> >     shutil.rmtree(path)
> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
> >     rmtree(fullname, ignore_errors, onerror)
> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
> >     rmtree(fullname, ignore_errors, onerror)
> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in rmtree
> >     rmtree(fullname, ignore_errors, onerror)
> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 256, in rmtree
> >     onerror(os.rmdir, path, sys.exc_info())
> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 254, in rmtree
> >     os.rmdir(path)
> > WindowsError: [Error 145] The directory is not empty:
> > 'd:\\src\\cr3\\src\\out\\Release_x64\\gen\\device\\bluetooth'
> > Error: Command d:\src\depot_tools\python276_bin\python.exe
> > src/build/landmines.py returned non-zero exit status 1 in d:\src\cr3
> 
> Worked the third time. Maybe we need to have a customized rmtree for the
> awesomeness of NTFS.

yep that's definitely strange

the implementation of shutil.rmtree is essentially a fancier version of what I
wrote:
http://svn.python.org/projects/python/trunk/Lib/shutil.py

[scottmg, 2014-09-04 16:55:11]

Yeah OK, thanks. No one yelled about any bots flaking that I know of, so I
vote for ignoring the problem until/unless it recurs.


On Thu, Sep 4, 2014 at 9:43 AM, <scherkus@chromium.org> wrote:

> On 2014/09/04 16:36:57, scottmg wrote:
>
>> On 2014/09/04 16:29:02, scottmg wrote:
>> > Hm, I'm not sure if it's related to this or not, but clobber is failing
>> for
>>
> me
>
>> > this morning
>> >
>> > I assume os.listdir just walks the dir, but maybe it's doing something
>> wacky...
>> > or ... hmm.
>> >
>> > d:\src\cr3\src>gclient sync
>> > Syncing projects: 100% (133/133), done.
>> >
>> > ________ running 'd:\src\depot_tools\python276_bin\python.exe
>> > src/build/landmines.py' in 'd:\src\cr3'
>> > Clobbering due to:
>> > --- old_landmines       Thu Aug 14 14:23:08 2014
>> > +++ new_landmines       Thu Sep 04 09:21:37 2014
>> > @@ -11,0 +12 @@
>> > +ninja dependency cycle: crbug.com/408192
>> > Traceback (most recent call last):
>> >   File "src/build/landmines.py", line 137, in <module>
>> >     sys.exit(main())
>> >   File "src/build/landmines.py", line 131, in main
>> >     clobber_if_necessary(landmines)
>> >   File "src/build/landmines.py", line 81, in clobber_if_necessary
>> >     shutil.rmtree(path)
>> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in
>> rmtree
>> >     rmtree(fullname, ignore_errors, onerror)
>> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in
>> rmtree
>> >     rmtree(fullname, ignore_errors, onerror)
>> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in
>> rmtree
>> >     rmtree(fullname, ignore_errors, onerror)
>> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 256, in
>> rmtree
>> >     onerror(os.rmdir, path, sys.exc_info())
>> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 254, in
>> rmtree
>> >     os.rmdir(path)
>> > WindowsError: [Error 145] The directory is not empty:
>> > 'd:\\src\\cr3\\src\\out\\Release_x64\\gen\\content\\app'
>> > Error: Command d:\src\depot_tools\python276_bin\python.exe
>> > src/build/landmines.py returned non-zero exit status 1 in d:\src\cr3
>> > Hook ''d:\src\depot_tools\python276_bin\python.exe'
>> src/build/landmines.py'
>> took
>> > 25.72 secs
>> >
>> > [skia-font-refs]d:\src\cr3\src>gclient sync
>> > Syncing projects: 100% (133/133), done.
>> >
>> > ________ running 'd:\src\depot_tools\python276_bin\python.exe
>> > src/build/landmines.py' in 'd:\src\cr3'
>> > Clobbering due to:
>> > --- old_landmines       Thu Aug 14 14:23:08 2014
>> > +++ new_landmines       Thu Sep 04 09:22:44 2014
>> > @@ -11,0 +12 @@
>> > +ninja dependency cycle: crbug.com/408192
>> > Traceback (most recent call last):
>> >   File "src/build/landmines.py", line 137, in <module>
>> >     sys.exit(main())
>> >   File "src/build/landmines.py", line 131, in main
>> >     clobber_if_necessary(landmines)
>> >   File "src/build/landmines.py", line 81, in clobber_if_necessary
>> >     shutil.rmtree(path)
>> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in
>> rmtree
>> >     rmtree(fullname, ignore_errors, onerror)
>> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in
>> rmtree
>> >     rmtree(fullname, ignore_errors, onerror)
>> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 247, in
>> rmtree
>> >     rmtree(fullname, ignore_errors, onerror)
>> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 256, in
>> rmtree
>> >     onerror(os.rmdir, path, sys.exc_info())
>> >   File "d:\src\depot_tools\python276_bin\lib\shutil.py", line 254, in
>> rmtree
>> >     os.rmdir(path)
>> > WindowsError: [Error 145] The directory is not empty:
>> > 'd:\\src\\cr3\\src\\out\\Release_x64\\gen\\device\\bluetooth'
>> > Error: Command d:\src\depot_tools\python276_bin\python.exe
>> > src/build/landmines.py returned non-zero exit status 1 in d:\src\cr3
>>
>
>  Worked the third time. Maybe we need to have a customized rmtree for the
>> awesomeness of NTFS.
>>
>
> yep that's definitely strange
>
> the implementation of shutil.rmtree is essentially a fancier version of
> what I
> wrote:
> http://svn.python.org/projects/python/trunk/Lib/shutil.py
>
> https://codereview.chromium.org/532323002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-09-10 03:27:51]

Patchset 1 (id:??) landed as
https://crrev.com/bb04e1054366543cb554531c728b33525a5dae8c
Cr-Commit-Position: refs/heads/master@{#293199}