Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 532303002: Revert of Reland 501823002: Used native deinterleaved and float point format for the input streams (Closed)

Created:
6 years, 3 months ago by no longer working on chromium
Modified:
6 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland 501823002: Used native deinterleaved and float point format for the input streams (patchset #4 id:80001 of https://codereview.chromium.org/510073002/) Reason for revert: It is speculated that this CL is blamed for crbug/409819, I temporarily revert it to be able to verify it on canary. Original issue's description: > Used native deinterleaved and float point format for the input streams. > > If we call GetProperty of kAudioUnitProperty_StreamFormat before setting the format, the device will report kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved as the native format of the device, which is the same as the output. > > This patch changes the format to use kAudioFormatFlagsNativeFloatPacked | kLinearPCMFormatFlagIsNonInterleaved to open the device, so that we will avoid format flipping back and forth. Hope this optimization will help increase the stability of the input audio on Mac. > > TBR=DaleCurtis@chromium.org > > BUG=404884 > TEST=media_unittests && https://webrtc.googlecode.com/svn-history/r5497/trunk/samples/js/demos/html/pc1.html, https://www.google.com/intl/en/chrome/demos/speech.html > > Committed: https://chromium.googlesource.com/chromium/src/+/2c732c000e18a6decd1da8da24e1f5f9e5f16833 TBR=dalecurtis@chromium.org NOTREECHECKS=true NOTRY=true BUG=404884 Committed: https://crrev.com/6e5a8c5087c7f6d827d5eb39996a4065d2397a0b Cr-Commit-Position: refs/heads/master@{#293156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -233 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.h View 5 chunks +7 lines, -12 lines 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.cc View 17 chunks +100 lines, -129 lines 0 comments Download
M media/base/audio_block_fifo.h View 2 chunks +0 lines, -7 lines 0 comments Download
M media/base/audio_block_fifo.cc View 3 chunks +8 lines, -38 lines 0 comments Download
M media/base/audio_block_fifo_unittest.cc View 6 chunks +26 lines, -47 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
no longer working on chromium
Created Revert of Reland 501823002: Used native deinterleaved and float point format for the input ...
6 years, 3 months ago (2014-09-03 16:44:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/532303002/1
6 years, 3 months ago (2014-09-03 16:44:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as c2332215db30c0cba4a3e276b5f8b30f1cff2ce0
6 years, 3 months ago (2014-09-03 16:59:56 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:26:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e5a8c5087c7f6d827d5eb39996a4065d2397a0b
Cr-Commit-Position: refs/heads/master@{#293156}

Powered by Google App Engine
This is Rietveld 408576698