Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 532293002: libjingle: Removes all references to talk/sound. The current reference comes from cl 153321 where i… (Closed)

Created:
6 years, 3 months ago by hellner1
Modified:
6 years, 3 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

libjingle: Removes all references to talk/sound. The current reference comes from cl 153321 where it was added under the flag enabled_libjingle_device_manager which is by default set to 0. The comment in that cl says it is to enable using this gyp file in the standalone build. This means that the code was never intended to be built for Chromium. Since that cl was committed the approach has changed. We are now creating new gyp files in the standalone build, containing parts of libjingle and phasing out libjingle.gyp one piece at a time. The files removed in this cl are part of (../webrtc's) sound.gyp which is not (and will not be) built in Chromium. The reason it is in webrtc is that libjingle and webrtc are being merged into one project. BUG=https://code.google.com/p/webrtc/issues/detail?id=3379 Committed: https://crrev.com/1ebcd949b86c6c36f5d5887af41982f54c4a0baf Cr-Commit-Position: refs/heads/master@{#293806}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M third_party/libjingle/libjingle.gyp View 1 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
hellner1
PTAL
6 years, 3 months ago (2014-09-03 18:01:28 UTC) #2
Alpha Left Google
lgtm
6 years, 3 months ago (2014-09-03 18:02:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hellner@chromium.org/532293002/1
6 years, 3 months ago (2014-09-03 18:04:27 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-03 19:17:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hellner@chromium.org/532293002/20001
6 years, 3 months ago (2014-09-08 22:03:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hellner@chromium.org/532293002/20001
6 years, 3 months ago (2014-09-08 22:08:44 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 44f80938562f87827ab062172687a4b0380a7080
6 years, 3 months ago (2014-09-08 23:04:31 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:48:48 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1ebcd949b86c6c36f5d5887af41982f54c4a0baf
Cr-Commit-Position: refs/heads/master@{#293806}

Powered by Google App Engine
This is Rietveld 408576698