Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 532283003: Add a helper function in TabObserver.java to handle WebContents Instant support disabled event. (Closed)

Created:
6 years, 3 months ago by kmadhusu
Modified:
6 years, 3 months ago
Reviewers:
Yaron
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a helper function in TabObserver.java to handle WebContents Instant support disabled event. Server side bug: b/17140979 BUG=none TEST=none Committed: https://crrev.com/ce3ea2a908ea4dab3565119ddc49eaa8380a8216 Cr-Commit-Position: refs/heads/master@{#293182}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kmadhusu
Please review. Thanks.
6 years, 3 months ago (2014-09-03 17:20:36 UTC) #2
Yaron
lgtm https://codereview.chromium.org/532283003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://codereview.chromium.org/532283003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode1026 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1026: public void onWebContentsInstantSupportDisabled() { this can be private ...
6 years, 3 months ago (2014-09-03 17:31:33 UTC) #3
kmadhusu
Thanks. https://codereview.chromium.org/532283003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://codereview.chromium.org/532283003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode1026 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1026: public void onWebContentsInstantSupportDisabled() { On 2014/09/03 17:31:32, Yaron ...
6 years, 3 months ago (2014-09-03 17:42:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/532283003/20001
6 years, 3 months ago (2014-09-03 17:49:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 31d7a2006ed54df940635de971b673067eaafd0b
6 years, 3 months ago (2014-09-03 19:06:31 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:27:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce3ea2a908ea4dab3565119ddc49eaa8380a8216
Cr-Commit-Position: refs/heads/master@{#293182}

Powered by Google App Engine
This is Rietveld 408576698