Fix scheme's toLowerCase detection.

sdk/lib/core/uri.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.core;
 
 /**
  * A parsed URI, such as a URL.
  *
  * **See also:**
@@ skipping 1084 matching lines @@
     return buffer.toString();
   }
 
   /**
    * Validates scheme characters and does case-normalization.
    *
    * Schemes are converted to lower case. They cannot contain escapes.
    */
   static String _makeScheme(String scheme, int end) {
     if (end == 0) return "";
-    int char = scheme.codeUnitAt(0);
-    if (!_isAlphabeticCharacter(char)) {
+    final int firstCodeUnit = scheme.codeUnitAt(0);
+    if (!_isAlphabeticCharacter(firstCodeUnit)) {
       _fail(scheme, 0, "Scheme not starting with alphabetic character");
     }
-    bool allLowercase = char >= _LOWER_CASE_A;
+    bool allLowercase = firstCodeUnit >= _LOWER_CASE_A;
     for (int i = 0; i < end; i++) {
-      int codeUnit = scheme.codeUnitAt(i);
+      final int codeUnit = scheme.codeUnitAt(i);
       if (!_isSchemeCharacter(codeUnit)) {
         _fail(scheme, i, "Illegal scheme character");
       }
-      if (_LOWER_CASE_A <= char && _LOWER_CASE_Z >= char) {

[Lasse Reichstein Nielsen, 2014/09/04 05:57:14]

whoops.

[Anders Johnsen, 2014/09/04 06:27:57]

Heh, copy paste :)

+      if (codeUnit < _LOWER_CASE_A || codeUnit > _LOWER_CASE_Z) {
         allLowercase = false;
       }
     }
     scheme = scheme.substring(0, end);

[Lasse Reichstein Nielsen, 2014/09/04 05:57:14]

It really, really sucks that we don't have cheap string slices.

How about having:

  StringSlice String.slice(int start, int end)

where StringSlice implements almost the same interface as String, isn't actually
a String (just a CharSequence ... I spot a Java inspiration)..

Then you could do scheme.slice(0, end).toLowerCase() and get the same as
scheme.substring(0, end).toLowerCase(), but without creating the substring.

That only really makes sense if the slice object (header, reference to string,
start-index, end-index) is smaller than the actual substring (header, length,
characters), which it probably isn't here, since schemes are usually short and
already lower-case.

[Anders Johnsen, 2014/09/04 06:27:57]

That's not a bad idea. Lets discuss it offline.

     if (!allLowercase) scheme = scheme.toLowerCase();
     return scheme;
   }
 
   static String _makeUserInfo(String userInfo, int start, int end) {
     if (userInfo == null) return "";
     return _normalize(userInfo, start, end, _userinfoTable);
   }
 
   static String _makePath(String path, int start, int end,
@@ skipping 1238 matching lines @@
       0xafff,   // 0x30 - 0x3f  1111111111110101
                 //              @ABCDEFGHIJKLMNO
       0xffff,   // 0x40 - 0x4f  1111111111111111
                 //              PQRSTUVWXYZ    _
       0x87ff,   // 0x50 - 0x5f  1111111111100001
                 //               abcdefghijklmno
       0xfffe,   // 0x60 - 0x6f  0111111111111111
                 //              pqrstuvwxyz   ~
       0x47ff];  // 0x70 - 0x7f  1111111111100010
 }