Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 53223002: Enable -Wall on Linux as well. (Closed)

Created:
7 years, 1 month ago by lgombos
Modified:
7 years, 1 month ago
Reviewers:
Nico, dglazkov
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable -Wall on Linux as well. BUG=312287 TBR=dglazkov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/config.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
lgombos
All warnings are fixed for Linux as well. Enable -Wall for Linux just like for ...
7 years, 1 month ago (2013-10-30 20:09:50 UTC) #1
Nico
Lgtm On Oct 30, 2013 1:09 PM, <l.gombos@samsung.com> wrote: > Reviewers: Nico, Dimitri Glazkov, > ...
7 years, 1 month ago (2013-10-30 20:24:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/53223002/1
7 years, 1 month ago (2013-10-30 20:34:46 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=10212
7 years, 1 month ago (2013-10-30 20:51:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/53223002/1
7 years, 1 month ago (2013-10-30 20:55:01 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 23:11:14 UTC) #6
Message was sent while issue was closed.
Change committed as 160985

Powered by Google App Engine
This is Rietveld 408576698