DevTools: [Documentation] Update empty page style

DevTools: [Documentation] Update empty page style

FYI: screenshot is available here: https://code.google.com/p/chromium/issues/detail?id=391593#c30

BUG=391593
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181721

[semeny, 2014-09-03 12:11:16]

semeny@google.com changed reviewers:
+ iliia@google.com, lushnikov@chromium.org

[lushnikov, 2014-09-03 15:06:39]

https://codereview.chromium.org/532223002/diff/1/Source/devtools/front_end/do...
File Source/devtools/front_end/documentationView.css (right):

https://codereview.chromium.org/532223002/diff/1/Source/devtools/front_end/do...
Source/devtools/front_end/documentationView.css:108: color: rgb(75%, 75%, 75%);
lets use integers instead of percentage

https://codereview.chromium.org/532223002/diff/1/Source/devtools/front_end/do...
Source/devtools/front_end/documentationView.css:116: white-space: pre-wrap;
wait.. do we need all these styles?..

[semeny, 2014-09-04 13:27:40]

Patchset #2 (id:20001) has been deleted

[semeny, 2014-09-04 13:30:40]

Patchset #2 (id:40001) has been deleted

[lushnikov, 2014-09-05 11:39:52]

On 2014/09/03 15:06:39, lushnikov wrote:
>
https://codereview.chromium.org/532223002/diff/1/Source/devtools/front_end/do...
> File Source/devtools/front_end/documentationView.css (right):
> 
>
https://codereview.chromium.org/532223002/diff/1/Source/devtools/front_end/do...
> Source/devtools/front_end/documentationView.css:108: color: rgb(75%, 75%,
75%);
> lets use integers instead of percentage
> 
>
https://codereview.chromium.org/532223002/diff/1/Source/devtools/front_end/do...
> Source/devtools/front_end/documentationView.css:116: white-space: pre-wrap;
> wait.. do we need all these styles?..

You should use display: flex on container to center inner node via
justify-content and align-items (instead of auto-margins and position: absolute)

[lushnikov, 2014-09-09 11:37:24]

any update on this?

[semeny, 2014-09-09 14:23:33]

semeny@google.com changed reviewers:
+ loislo@chromium.org

[semeny, 2014-09-09 14:27:22]

Patchset #3 (id:80001) has been deleted

[lushnikov, 2014-09-09 14:34:02]

https://codereview.chromium.org/532223002/diff/100001/Source/devtools/front_e...
File Source/devtools/front_end/documentation/DocumentationView.js (right):

https://codereview.chromium.org/532223002/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/documentation/DocumentationView.js:13:
this.element.classList.add("vbox");
I believe we want to use this only for empty page

https://codereview.chromium.org/532223002/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/documentation/DocumentationView.js:81: var
alignElement = this.element.createChild("div",
"documentation-empty-page-align");
No need for the variable.

this.element.createChild("div", "documentation-empty-page-bottom-padding");

https://codereview.chromium.org/532223002/diff/100001/Source/devtools/front_e...
File Source/devtools/front_end/documentationView.css (right):

https://codereview.chromium.org/532223002/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/documentationView.css:102: font-size: 24px;
can we use 160% here? should be almost the same

https://codereview.chromium.org/532223002/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/documentationView.css:104: color: rgb(75%, 75%, 75%);
can we use integers instead of percentage?

[semeny, 2014-09-09 15:38:07]

https://codereview.chromium.org/532223002/diff/100001/Source/devtools/front_e...
File Source/devtools/front_end/documentation/DocumentationView.js (right):

https://codereview.chromium.org/532223002/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/documentation/DocumentationView.js:13:
this.element.classList.add("vbox");
On 2014/09/09 14:34:02, lushnikov wrote:
> I believe we want to use this only for empty page

Done.

https://codereview.chromium.org/532223002/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/documentation/DocumentationView.js:81: var
alignElement = this.element.createChild("div",
"documentation-empty-page-align");
On 2014/09/09 14:34:02, lushnikov wrote:
> No need for the variable.
> 
> this.element.createChild("div", "documentation-empty-page-bottom-padding");

Done.

https://codereview.chromium.org/532223002/diff/100001/Source/devtools/front_e...
File Source/devtools/front_end/documentationView.css (right):

https://codereview.chromium.org/532223002/diff/100001/Source/devtools/front_e...
Source/devtools/front_end/documentationView.css:104: color: rgb(75%, 75%, 75%);
On 2014/09/09 14:34:02, lushnikov wrote:
> can we use integers instead of percentage?

Done.

[loislo, 2014-09-10 06:18:15]

https://codereview.chromium.org/532223002/diff/120001/Source/devtools/front_e...
File Source/devtools/front_end/documentationView.css (right):

https://codereview.chromium.org/532223002/diff/120001/Source/devtools/front_e...
Source/devtools/front_end/documentationView.css:99: display: flex;
do we actually need this property on the title.

https://codereview.chromium.org/532223002/diff/120001/Source/devtools/front_e...
Source/devtools/front_end/documentationView.css:101: align-items: flex-end;
I'm not sure that we need this property. Could you please clarify why we need
it.

[semeny, 2014-09-10 09:05:00]

https://codereview.chromium.org/532223002/diff/120001/Source/devtools/front_e...
File Source/devtools/front_end/documentationView.css (right):

https://codereview.chromium.org/532223002/diff/120001/Source/devtools/front_e...
Source/devtools/front_end/documentationView.css:101: align-items: flex-end;
On 2014/09/10 06:18:15, loislo wrote:
> I'm not sure that we need this property. Could you please clarify why we need
> it.

We need to use flex and other flex properties to align text just in center of
the tab.

[loislo, 2014-09-10 09:07:16]

The CQ bit was checked by loislo@chromium.org

[loislo, 2014-09-10 09:07:17]

lgtm

[commit-bot: I haz the power, 2014-09-10 09:07:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/semeny@google.com/532223002/120001

[commit-bot: I haz the power, 2014-09-10 10:10:10]

Committed patchset #4 (id:120001) as 181721