Chromium Code Reviews Chromium Code Reviews
Issue 532203002:
Test: Don't add scrollbar width to intrinsic width of fixed-width grid items (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid.html |
| diff --git a/LayoutTests/fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid.html b/LayoutTests/fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..228e40e7bb138ea11c150b9151f2505b049aef29 |
| --- /dev/null |
| +++ b/LayoutTests/fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid.html |
| @@ -0,0 +1,55 @@ |
| +<!DOCTYPE html> |
| +<html> |
| +<link href="resources/grid.css" rel="stylesheet"> |
| +<style> |
| +.grid { |
| + grid-template-columns: 200px 200px; |
| + grid-template-rows: 200px 200px; |
| +} |
| + |
| +.firstRowFirstColumn { |
| + color: blue; |
| + background: red; |
| + overflow: scroll; |
| + width:50px; |
| + height:50px; |
| +} |
| + |
| +.firstRowSecondColumn { |
| + color: yellow; |
| + background: green; |
| + overflow: scroll; |
| + width:50px; |
| + height:50px; |
| +} |
| + |
| +.secondRowFirstColumn { |
| + color: gray; |
| + background: pink; |
| + overflow: scroll; |
| + width:50px; |
| + height:50px; |
| +} |
| + |
| +.secondRowSecondColumn { |
| + color: orange; |
| + background: brown; |
| + overflow: scroll; |
| + width:50px; |
| + height:50px; |
|
Julien - ping for review
2014/09/03 15:35:14
All the styles are the same (apart from the colors
Julien - ping for review
2014/09/03 15:35:14
All the styles are the same (apart from the colors
Sunil Ratnu
2014/09/04 10:29:21
Done.
|
| +} |
| +</style> |
| +<script src="../../resources/check-layout.js"></script> |
| +<body onload="checkLayout('.grid')"> |
| + |
| +<p>This test checks that scrollbar width should not be added to the intrinsic width of fixed-width grid items.</p> |
|
Julien - ping for review
2014/09/03 15:35:14
data-expected-width measures the actual width, not
Julien - ping for review
2014/09/03 15:35:14
data-expected-width measures the actual width, not
Sunil Ratnu
2014/09/04 10:29:21
Done.The main thing which I wish to check here is
Julien - ping for review
2014/09/05 17:32:12
Thanks for the context. It would be way better to
|
| + |
| +<div class="grid"> |
| + <div class="firstRowFirstColumn" data-expected-width="50" data-expected-height="50"></div> |
| + <div class="firstRowSecondColumn" data-expected-width="50" data-expected-height="50"></div> |
| + <div class="secondRowFirstColumn" data-expected-width="50" data-expected-height="50"></div> |
| + <div class="secondRowSecondColumn" data-expected-width="50" data-expected-height="50"></div> |
| +</div> |
| + |
| +</body> |
| +</html> |
