LayoutTests/fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid.html - Issue 532203002: Test: Don't add scrollbar width to intrinsic width of fixed-width grid items

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid.html

Issue 532203002: Test: Don't add scrollbar width to intrinsic width of fixed-width grid items (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Incorporating review comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/fixed-width-intrinsic-width-should-exclude-scrollbar-width-in-grid-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <link href="resources/grid.css" rel="stylesheet">

	4 <style>

	5 .grid {

	6 grid-template-columns: 200px 200px;

	7 grid-template-rows: 200px 200px;
	Julien - ping for review 2014/09/05 17:32:13 I would change the grid cells' sizes to have more I would change the grid cells' sizes to have more variety. Sunil Ratnu 2014/09/06 12:36:10 Done. Show quoted text On 2014/09/05 17:32:13, Julien Chaffraix - PST wrote: > I would change the grid cells' sizes to have more variety. Done.
	8 }

	9

	10 .gridItemScrollOverflow {

	11 width: 50px;

	12 height: 50px;

	13 overflow: scroll;

	14 }

	15

	16 </style>

	17 <script src="../../resources/check-layout.js"></script>

	18 <body onload="checkLayout('.grid')">

	19

	20 <p>This test checks that scrollbar width should not be added to the width of fix ed-width grid items.</p>

	21

	22 <div class="grid">

	23 <div class="firstRowFirstColumn gridItemScrollOverflow" data-expected-width= "50" data-expected-height="50"></div>

	24 <div class="firstRowSecondColumn gridItemScrollOverflow" data-expected-width ="50" data-expected-height="50"></div>

	25 <div class="secondRowFirstColumn gridItemScrollOverflow" data-expected-width ="50" data-expected-height="50"></div>

	26 <div class="secondRowSecondColumn gridItemScrollOverflow" data-expected-widt h="50" data-expected-height="50"></div>
	Julien - ping for review 2014/09/05 17:32:13 We will want one of the grid items to be also a gr We will want one of the grid items to be also a grid container for better coverage. Julien - ping for review 2014/09/05 17:32:13 We will want one of the grid items to be also a gr We will want one of the grid items to be also a grid container for better coverage. Sunil Ratnu 2014/09/06 12:36:10 Done. Show quoted text On 2014/09/05 17:32:13, Julien Chaffraix - PST wrote: > We will want one of the grid items to be also a grid container for better > coverage. Done.
	27 </div>

	28

	29 </body>

	30 </html>

OLD	NEW