Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 532183003: Revert of Enable forced extension updates on NaCl arch mismatch (Closed)

Created:
6 years, 3 months ago by dzhioev (left Google)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, waffles, Nick Bray (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable forced extension updates on NaCl arch mismatch (patchset #5 id:100001 of https://codereview.chromium.org/516293007/) Reason for revert: Chrome OS build with DCHECKs enabled fails on start. This CL breaks assumption, that GAIA extension can be loaded without performing IO-operations. Original issue's description: > Enable forced extension updates on NaCl arch mismatch > > This makes extensions aware of the platforms for which > they have platform-specific resources installed, if any. > > This also hooks up the extension update code with some > additional logic to place an extension in forced-update > mode if it has platform-specific resources which don't > match the current NaCl architecture. > > BUG=409948 > TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed. > > Committed: https://chromium.googlesource.com/chromium/src/+/4a92281fa5d331860d65a59ba45dc882a5c71df4 TBR=sorin@chromium.org,yoz@chromium.org,shuchen@chromium.org,rockot@chromium.org NOTREECHECKS=true NOTRY=true BUG=409948 Committed: https://crrev.com/dd6d036ac96067e8613f8c296625d9a049245a32 Cr-Commit-Position: refs/heads/master@{#293128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -134 lines) Patch
M chrome/browser/extensions/updater/extension_downloader.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 11 chunks +18 lines, -48 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 10 chunks +14 lines, -18 lines 0 comments Download
M chrome/browser/extensions/updater/manifest_fetch_data.h View 3 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/extensions/updater/manifest_fetch_data.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M extensions/common/extension.h View 2 chunks +0 lines, -7 lines 0 comments Download
M extensions/common/extension.cc View 4 chunks +0 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dzhioev (left Google)
Created Revert of Enable forced extension updates on NaCl arch mismatch
6 years, 3 months ago (2014-09-03 12:44:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/532183003/1
6 years, 3 months ago (2014-09-03 12:44:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 68bb1aba0c30044640c1c67012ed1c7edd4f9eb0
6 years, 3 months ago (2014-09-03 12:46:07 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:25:29 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd6d036ac96067e8613f8c296625d9a049245a32
Cr-Commit-Position: refs/heads/master@{#293128}

Powered by Google App Engine
This is Rietveld 408576698