Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 532173002: Disable app_mode_chrome_locator_browsertest.mm on official builds. (Closed)

Created:
6 years, 3 months ago by jackhou1
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek, tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable app_mode_chrome_locator_browsertest.mm on official builds. The test assumes the "Google Chrome.app" bundle is in the same directory as the browser_tests binary. It probably isn't on the official builders. Disable these until we have a workaround. TBR=tapted@chromium.org, rsesek@chromium.org BUG=409615 Committed: https://crrev.com/c3cf6485f0845385c5d0a2acc1dba88709c0f373 Cr-Commit-Position: refs/heads/master@{#293101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M chrome/common/mac/app_mode_chrome_locator_browsertest.mm View 5 chunks +27 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/532173002/1
6 years, 3 months ago (2014-09-03 07:52:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as cbd80d899fc4e3f1838488a7da603bea063919cc
6 years, 3 months ago (2014-09-03 08:55:51 UTC) #4
Robert Sesek
lgtm
6 years, 3 months ago (2014-09-03 15:24:38 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:32 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3cf6485f0845385c5d0a2acc1dba88709c0f373
Cr-Commit-Position: refs/heads/master@{#293101}

Powered by Google App Engine
This is Rietveld 408576698