Chromium Code Reviews| Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc |
| diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc |
| index 865e9768f024d3d4a8a28e422e4c6531aee1799a..4e518d25d8ac327d5e6f66af9b85a7575951aa2b 100644 |
| --- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc |
| +++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc |
| @@ -839,7 +839,10 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, |
| EXPECT_EQ(1, ordinal); |
| } |
| -IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindDisappearOnNavigate) { |
| +// This test will verify that after reload Findbar should get disappeared |
| +// and on navigation to new page also Findbar should get disappeared. |
|
Finnur
2014/09/04 15:58:51
This comment is confusing. Suggest:
// This test
Deepak
2014/09/05 04:16:07
Done.
|
| +IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, |
| + FindDisappearOnNavigateAndReload) { |
| // First we navigate to our special focus tracking page. |
| GURL url = GetURL(kSimple); |
| GURL url2 = GetURL(kFramePage); |
| @@ -854,7 +857,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindDisappearOnNavigate) { |
| EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible)); |
| EXPECT_TRUE(fully_visible); |
| - // Reload the tab and make sure Find window doesn't go away. |
| + // Reload and make sure the Find window goes away. |
| content::WindowedNotificationObserver observer( |
| content::NOTIFICATION_LOAD_STOP, |
| content::Source<NavigationController>( |
| @@ -862,7 +865,13 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindDisappearOnNavigate) { |
| GetController())); |
| chrome::Reload(browser(), CURRENT_TAB); |
| observer.Wait(); |
| + EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible)); |
| + EXPECT_FALSE(fully_visible); |
| + // Opening Findbar again. |
| + chrome::ShowFindBar(browser()); |
| + |
| + // Make sure it is open. |
| EXPECT_TRUE(GetFindBarWindowInfo(&position, &fully_visible)); |
| EXPECT_TRUE(fully_visible); |