src/x87/code-stubs-x87.cc - Issue 532133002: X87: First step to cleanup the power-of-2 mess

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x87/code-stubs-x87.cc

Issue 532133002: X87: First step to cleanup the power-of-2 mess (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x87/code-stubs-x87.cc

diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc

index 94d13a0bc95ae7e7810fa2867853f2d15b0dcec8..8f28607491a2413dc22fd2e1b989a2c4fe546eee 100644

--- a/src/x87/code-stubs-x87.cc

+++ b/src/x87/code-stubs-x87.cc

@@ -6,6 +6,7 @@

#if V8_TARGET_ARCH_X87

+#include "src/base/bits.h"

#include "src/bootstrapper.h"

#include "src/code-stubs.h"

#include "src/codegen.h"

@@ -2508,7 +2509,7 @@ void StringCharFromCodeGenerator::GenerateFast(MacroAssembler* masm) {

// Fast case of Heap::LookupSingleCharacterStringFromCode.

STATIC_ASSERT(kSmiTag == 0);

STATIC_ASSERT(kSmiShiftSize == 0);

- DCHECK(IsPowerOf2(String::kMaxOneByteCharCode + 1));

+ DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCode + 1));

__ test(code_,

Immediate(kSmiTagMask |

((~String::kMaxOneByteCharCode) << kSmiTagSize)));

« no previous file with comments | « src/x87/assembler-x87.cc ('k') | src/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »