[Profiles] Trim profile names in chrome://settings

chrome/browser/resources/options/manage_profile_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var ArrayDataModel = cr.ui.ArrayDataModel;
 
   /**
@@ skipping 376 matching lines @@
           }
           var self = this;
           function getImportHandler(supervisedUser, nameIsUnique) {
             return function() {
               if (supervisedUser.needAvatar || !nameIsUnique) {
                 PageManager.showPageByName('supervisedUserImport');
               } else {
                 self.hideErrorBubble_('create');
                 CreateProfileOverlay.updateCreateInProgress(true);
                 chrome.send('createProfile',
-                    [supervisedUser.name, supervisedUser.iconURL, false, true,
-                         supervisedUser.id]);
+                    [supervisedUser.name.trim(), supervisedUser.iconURL,
+                        false, true, supervisedUser.id]);
               }
             }
           };
           $('supervised-user-import-existing').onclick =
               getImportHandler(supervisedUsers[i], nameIsUnique);
           $('create-profile-ok').disabled = true;
           return;
         }
       }
     },
 
     /**
      * Called in case the request for the list of supervised users fails because
      * of a signin error.
      * @private
      */
     onSigninError_: function() {
       this.updateSignedInStatus_(this.signedInEmail_, true);
     },
 
     /**
      * Called to update the state of the ok button depending if the name is
      * already used or not.
      * @param {string} mode A label that specifies the type of dialog box which
      *     is currently being viewed (i.e. 'create' or 'manage').
      * @private
      */
     updateOkButton_: function(mode) {
+      var nameElement = $(mode + '-profile-name');

[Dan Beam, 2014/09/04 23:06:07]

nit: move a line lower (right above first use)

       var oldName = this.profileInfo_.name;
-      var newName = $(mode + '-profile-name').value;
+      var newName = nameElement.value;
       var nameIsDuplicate = this.existingProfileNames_[newName] != undefined;
       if (mode == 'manage' && oldName == newName)
         nameIsDuplicate = false;
+
       if (nameIsDuplicate) {
         var errorHtml =
             loadTimeData.getString('manageProfilesDuplicateNameError');
         this.showErrorBubble_(errorHtml, mode, true);
       } else {
         this.hideErrorBubble_(mode);
 
-        var nameIsValid = $(mode + '-profile-name').validity.valid;
+        // A name containing all spaces is not valid.
+        nameElement.setCustomValidity(newName.trim() == '' ? ' ' : '');
+
+        var nameIsValid = nameElement.validity.valid;
         $(mode + '-profile-ok').disabled = !nameIsValid;
       }
     },
 
     /**
      * Called when the user clicks "OK" or hits enter. Saves the newly changed
      * profile info.
      * @private
      */
     submitManageChanges_: function() {
-      var name = $('manage-profile-name').value;
+      var name = $('manage-profile-name').value.trim();
       var iconURL = $('manage-profile-icon-grid').selectedItem;
 
       chrome.send('setProfileIconAndName',
                   [this.profileInfo_.filePath, iconURL, name]);
       if (name != this.profileInfo_.name)
         options.SupervisedUserListData.resetPromise();
     },
 
     /**
      * Called when the user clicks "OK" or hits enter. Creates the profile
@@ skipping 12 matching lines @@
       // Get the user's chosen name and icon, or default if they do not
       // wish to customize their profile.
       var name = $('create-profile-name').value;
       var iconUrl = $('create-profile-icon-grid').selectedItem;
       var createShortcut = $('create-shortcut').checked;
       var isSupervised = $('create-profile-supervised').checked;
       var existingSupervisedUserId = '';
 
       // 'createProfile' is handled by the CreateProfileHandler.
       chrome.send('createProfile',
-                  [name, iconUrl, createShortcut,
+                  [name.trim(), iconUrl, createShortcut,
                    isSupervised, existingSupervisedUserId]);
     },
 
     /**
      * Called when the selected icon in the icon grid changes.
      * @param {string} mode A label that specifies the type of dialog box which
      *     is currently being viewed (i.e. 'create' or 'manage').
      * @private
      */
     onIconGridSelectionChanged_: function(mode) {
@@ skipping 368 matching lines @@
       return instance[name + '_'].apply(instance, arguments);
     };
   });
 
   // Export
   return {
     ManageProfileOverlay: ManageProfileOverlay,
     CreateProfileOverlay: CreateProfileOverlay,
   };
 });