Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 531963003: Add missing histogram description. (Closed)

Created:
6 years, 3 months ago by rvargas (doing something else)
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add missing histogram description. This histogram was renamed a while ago :( BUG=336198 R=isherman@chromium.org Committed: https://crrev.com/70b215c8580f36ff0a63528cae3a7d23dd156fc9 Cr-Commit-Position: refs/heads/master@{#293039}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add obsolete to previous name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
rvargas (doing something else)
6 years, 3 months ago (2014-09-02 21:52:08 UTC) #1
Ilya Sherman
You mentioned that this histogram was renamed. Is there an older name that should be ...
6 years, 3 months ago (2014-09-02 22:22:03 UTC) #2
rvargas (doing something else)
Thanks https://codereview.chromium.org/531963003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/531963003/diff/1/tools/metrics/histograms/histograms.xml#newcode12618 tools/metrics/histograms/histograms.xml:12618: +<histogram name="MPArch.IIR_InputEventDelta" units="milliseconds"> On 2014/09/02 22:22:03, Ilya Sherman ...
6 years, 3 months ago (2014-09-02 22:48:00 UTC) #3
Ilya Sherman
LGTM https://codereview.chromium.org/531963003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/531963003/diff/1/tools/metrics/histograms/histograms.xml#newcode12618 tools/metrics/histograms/histograms.xml:12618: +<histogram name="MPArch.IIR_InputEventDelta" units="milliseconds"> On 2014/09/02 22:48:00, rvargas wrote: ...
6 years, 3 months ago (2014-09-02 23:28:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/531963003/20001
6 years, 3 months ago (2014-09-02 23:33:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 920d7c0dff290e4763aa698b2316a8a2094f9a86
6 years, 3 months ago (2014-09-03 01:22:24 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:22:31 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70b215c8580f36ff0a63528cae3a7d23dd156fc9
Cr-Commit-Position: refs/heads/master@{#293039}

Powered by Google App Engine
This is Rietveld 408576698