Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 531953002: Remove windows.onCreated hack from Keep Awake extension. (Closed)

Created:
6 years, 3 months ago by Daniel Erat
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, adverb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove windows.onCreated hack from Keep Awake extension. The example extension for the chrome.power API registered a listener for windows.onCreated to work around an issue where runtime.onStartup didn't fire on Chrome OS. The underlying Chrome bug has been fixed now, so the windows.onCreated workaround is no longer needed. BUG=222473 TEST=install the extension on Chrome OS and check that /var/log/power_manager/powerd.LATEST reports an extension-driven policy change when logging in Committed: https://crrev.com/3d20816f65b5b9f25e194ef725b94157bf2b1533 Cr-Commit-Position: refs/heads/master@{#293043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/common/extensions/docs/examples/api/power/background.js View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/power/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Daniel Erat
6 years, 3 months ago (2014-09-02 21:18:15 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-02 22:53:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/531953002/1
6 years, 3 months ago (2014-09-02 23:11:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ad0b6482455c6dba6aa115bfbc7afb407237b19e
6 years, 3 months ago (2014-09-03 01:42:50 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:22:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d20816f65b5b9f25e194ef725b94157bf2b1533
Cr-Commit-Position: refs/heads/master@{#293043}

Powered by Google App Engine
This is Rietveld 408576698