Chromium Code Reviews| Index: pkg/polymer/lib/src/build/build_filter.dart |
| diff --git a/pkg/polymer/lib/src/build/build_filter.dart b/pkg/polymer/lib/src/build/build_filter.dart |
| index 4b50fe1caf86e83941a2fb619e88046ba675c586..35b5bebfa3b1f64ee55827d34cafb35863a8db2a 100644 |
| --- a/pkg/polymer/lib/src/build/build_filter.dart |
| +++ b/pkg/polymer/lib/src/build/build_filter.dart |
| @@ -21,20 +21,22 @@ class BuildFilter extends Transformer with PolymerTransformer { |
| // is dropped. |
| Future<bool> isPrimary(idOrAsset) { |
| var id = idOrAsset is AssetId ? idOrAsset : idOrAsset.id; |
| + var isBuildArtifact = _BUILD_ARTIFACTS.contains(id.extension); |
| return new Future.value( |
|
Siggi Cherem (dart-lang)
2014/09/03 16:56:01
given our current dependency on barback 0.14.2 we
jakemac
2014/09/03 17:45:42
Done.
|
| // nothing is filtered in debug mode |
| options.releaseMode && |
| // TODO(sigmund): remove this exclusion once we have dev_transformers |
| // (dartbug.com/14187) |
| - id.path.startsWith('web/') && |
| + (isBuildArtifact || id.path.startsWith('web/')) && |
|
Siggi Cherem (dart-lang)
2014/09/03 16:56:01
maybe we should check `!id.path.startsWith('lib/')
Siggi Cherem (dart-lang)
2014/09/03 16:56:01
I think we no longer generate build artifacts exce
jakemac
2014/09/03 17:45:42
Good call, done
On 2014/09/03 16:56:01, Siggi Che
jakemac
2014/09/03 17:45:42
Done.
|
| // may filter non-entry HTML files and internal artifacts |
| - (id.extension == '.html' || id.extension == '.scriptUrls') && |
| + (id.extension == '.html' || isBuildArtifact) && |
| // keep any entry points |
| !options.isHtmlEntryPoint(id)); |
| } |
| Future apply(Transform transform) { |
| - if (transform.primaryInput.id.extension == '.scriptUrls') { |
| + transform.consumePrimary(); |
| + if (_BUILD_ARTIFACTS.contains(transform.primaryInput.id.extension)) { |
| return new Future.value(null); |
| } |
| return readPrimaryAsHtml(transform).then((document) { |
| @@ -46,3 +48,5 @@ class BuildFilter extends Transformer with PolymerTransformer { |
| }); |
| } |
| } |
| + |
| +const List<String> _BUILD_ARTIFACTS = const ['.scriptUrls', '._data']; |
|
Siggi Cherem (dart-lang)
2014/09/03 16:56:01
I think scriptUrls no longer exist, so we can chan
jakemac
2014/09/03 17:45:42
Done.
|