Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 531933002: Fix drawPosText() bounds bug. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix drawPosText() bounds bug. We didn't catch this in our local tests because we tend to use default kUTF8_TextEncoding with single-byte characters, which means N == byteLength. BUG=409110 Committed: https://skia.googlesource.com/skia/+/937c9c7eb4e06d4d3bc495e129c7b8103a5d6c0f

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : nit #

Patch Set 4 : reorg #

Patch Set 5 : get rid of line feed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M src/core/SkRecordDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecordDrawTest.cpp View 1 2 3 4 2 chunks +36 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mtklein
6 years, 3 months ago (2014-09-02 21:12:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/531933002/50001
6 years, 3 months ago (2014-09-02 21:12:28 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-02 21:12:29 UTC) #5
reed1
lgtm
6 years, 3 months ago (2014-09-02 21:18:07 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 3 months ago (2014-09-02 21:19:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/499)
6 years, 3 months ago (2014-09-02 21:22:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/531933002/70001
6 years, 3 months ago (2014-09-02 22:11:38 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-02 22:19:54 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:70001) as 937c9c7eb4e06d4d3bc495e129c7b8103a5d6c0f

Powered by Google App Engine
This is Rietveld 408576698