Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 531913002: Ensure that conversions from/to 8bit and 16bit never return null string. (Closed)

Created:
6 years, 3 months ago by reni
Modified:
6 years, 3 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, aandrey+blink_chromium.org, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@documentordered
Project:
blink
Visibility:
Public.

Description

Ensure that conversions from/to 8bit and 16bit never return null string. WTF::StringImpl::upconvertedString() relies on make16BitFrom8BitSource() return a valid (non-null) string, on which releaseImpl() can be called. The patch ensures that for zero length sources an empty string is returned. The same logic is applied to make8BitFrom16BitSource(). R=abarth@chromium.org BUG=409977 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
A LayoutTests/fast/text/text-transform-quoted-turkish-azeri-lithuanian-and-greek-crash.html View 1 chunk +22 lines, -0 lines 0 comments Download
A + LayoutTests/fast/text/text-transform-quoted-turkish-azeri-lithuanian-and-greek-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/wtf/text/WTFString.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
reni
6 years, 3 months ago (2014-09-02 21:32:29 UTC) #1
abarth-chromium
lgtm
6 years, 3 months ago (2014-09-02 21:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhodovan.u-szeged@partner.samsung.com/531913002/1
6 years, 3 months ago (2014-09-02 21:45:41 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-02 22:52:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181263

Powered by Google App Engine
This is Rietveld 408576698