Issue 531883002: use factories instead of manually setting fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 531883002: use factories instead of manually setting fields (Closed)

Created:
6 years, 3 months ago by reed1

Modified:
6 years, 3 months ago

Reviewers:
Stephen Chennney, f(malita)

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

use factories instead of manually setting fields this allows us to (later) land change in Skia where we add more fields Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181257

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -12 lines)			Patch
	M	Source/platform/graphics/DeferredImageDecoder.cpp	View		1 chunk	+3 lines, -6 lines	0 comments	Download
	M	Source/platform/graphics/ImageFrameGeneratorTest.cpp	View		1 chunk	+1 line, -6 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/531883002/1

6 years, 3 months ago (2014-09-02 19:46:07 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-02 20:51:36 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 181257