Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 531873002: Prospective fix for autofill crash (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prospective fix for autofill crash BUG=409349 Committed: https://crrev.com/d80f2526c38b3575f78d1e3335b2423110438c37 Cr-Commit-Position: refs/heads/master@{#294448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Evan Stade
not really sure if this just papers over the crash or is a legit fix.
6 years, 3 months ago (2014-09-02 18:32:04 UTC) #2
Evan Stade
ping
6 years, 3 months ago (2014-09-03 21:50:01 UTC) #3
Evan Stade
On 2014/09/03 21:50:01, Evan Stade wrote: > ping ping isherman
6 years, 3 months ago (2014-09-11 17:38:22 UTC) #4
Ilya Sherman
LGTM. Sorry, somehow missed the first two pings.
6 years, 3 months ago (2014-09-11 17:47:24 UTC) #5
Evan Stade
On 2014/09/11 17:47:24, Ilya Sherman wrote: > LGTM. Sorry, somehow missed the first two pings. ...
6 years, 3 months ago (2014-09-11 17:52:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/531873002/1
6 years, 3 months ago (2014-09-11 18:09:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as be9f9a2645950f5ec5ca9981b9f07d5e0c703204
6 years, 3 months ago (2014-09-11 19:59:22 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 20:02:42 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d80f2526c38b3575f78d1e3335b2423110438c37
Cr-Commit-Position: refs/heads/master@{#294448}

Powered by Google App Engine
This is Rietveld 408576698