Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 531763002: Lower simplified StringEqual to runtime call. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Lower simplified StringEqual to runtime call. R=titzer@chromium.org TEST=cctest/test-simplified-lowering/LowerStringOps_to_call_and_wordeq Committed: https://code.google.com/p/v8/source/detail?r=23616

Patch Set 1 #

Patch Set 2 : Minor readability improvement. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M src/compiler/simplified-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 chunks +23 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-02 12:16:24 UTC) #1
titzer
lgtm
6 years, 3 months ago (2014-09-02 12:30:09 UTC) #2
titzer
lgtm lgtm
6 years, 3 months ago (2014-09-02 12:30:09 UTC) #3
Michael Starzinger
6 years, 3 months ago (2014-09-02 13:27:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 23616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698