Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 53173007: [webcrypto] Make algorithm nullable in crypto.subtle.importKey(). (Closed)

Created:
7 years, 1 month ago by eroman
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

[webcrypto] Make algorithm nullable in crypto.subtle.importKey(). BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161084

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M LayoutTests/crypto/importKey.html View 1 chunk +8 lines, -12 lines 1 comment Download
M LayoutTests/crypto/importKey-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/modules/crypto/SubtleCrypto.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
https://codereview.chromium.org/53173007/diff/1/LayoutTests/crypto/importKey.html File LayoutTests/crypto/importKey.html (left): https://codereview.chromium.org/53173007/diff/1/LayoutTests/crypto/importKey.html#oldcode66 LayoutTests/crypto/importKey.html:66: keyFormat = "raw"; (This test was an exact duplicate, ...
7 years, 1 month ago (2013-10-31 06:54:05 UTC) #1
abarth-chromium
lgtm
7 years, 1 month ago (2013-10-31 18:05:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/53173007/1
7 years, 1 month ago (2013-10-31 18:05:23 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 19:45:24 UTC) #4
Message was sent while issue was closed.
Change committed as 161084

Powered by Google App Engine
This is Rietveld 408576698