Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 531613002: InputImeEventRouter::RegisterImeExtension should register extensions (Closed)

Created:
6 years, 3 months ago by Alexander Alekseev
Modified:
6 years, 3 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

InputImeEventRouter::RegisterImeExtension should register extensions to correct profile. BUG=409501, 407373 TEST=manual Committed: https://crrev.com/727c393de40ac9858cb696784068d229c17a70a0 Cr-Commit-Position: refs/heads/master@{#292911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/extensions/api/input_ime/input_ime_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Alexander Alekseev
This CL fixes the problem when RegisterImeExtension() is called for inactive IMM State. Please review.
6 years, 3 months ago (2014-09-01 17:42:22 UTC) #2
Shu Chen
lgtm
6 years, 3 months ago (2014-09-02 01:05:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/531613002/1
6 years, 3 months ago (2014-09-02 11:19:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 79132c4c5a2b8b8ac514d111c25b536bef2d3687
6 years, 3 months ago (2014-09-02 12:16:16 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:18:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/727c393de40ac9858cb696784068d229c17a70a0
Cr-Commit-Position: refs/heads/master@{#292911}

Powered by Google App Engine
This is Rietveld 408576698