Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issue 531583002: [android_webview] Don't call super.onMeasure in AwTestContainerView (Closed)

Created:
6 years, 3 months ago by mkosiba (inactive)
Modified:
6 years, 3 months ago
Reviewers:
boliu, no sievers
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[android_webview] Don't call super.onMeasure in AwTestContainerView It shouldn't matter much but the onMeasure method should be overridden without calling super. BUG=None TEST=None Committed: https://crrev.com/83ed44690ca93d4d1d1e92b8a69300a03dba1098 Cr-Commit-Position: refs/heads/master@{#292953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M android_webview/test/shell/src/org/chromium/android_webview/test/AwTestContainerView.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
mkosiba (inactive)
6 years, 3 months ago (2014-09-01 15:09:13 UTC) #2
boliu
rs lgtm
6 years, 3 months ago (2014-09-02 14:56:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/531583002/1
6 years, 3 months ago (2014-09-02 17:06:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8a343c07122c84791ce9eb8651bcca77e2f862df
6 years, 3 months ago (2014-09-02 17:43:44 UTC) #6
no sievers
WebView.onMeasure() calls super.onMeasure(), why wouldn't this? It breaks the measurement of the children if you ...
6 years, 3 months ago (2014-09-02 20:30:34 UTC) #7
no sievers
On 2014/09/02 20:30:34, sievers wrote: > WebView.onMeasure() calls super.onMeasure(), why wouldn't this? > > It ...
6 years, 3 months ago (2014-09-02 20:31:51 UTC) #8
boliu
On 2014/09/02 20:31:51, sievers wrote: > On 2014/09/02 20:30:34, sievers wrote: > > WebView.onMeasure() calls ...
6 years, 3 months ago (2014-09-02 20:42:09 UTC) #9
mkosiba (inactive)
On 2014/09/02 20:30:34, sievers wrote: > WebView.onMeasure() calls super.onMeasure(), why wouldn't this? > > It ...
6 years, 3 months ago (2014-09-03 08:50:06 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:19:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83ed44690ca93d4d1d1e92b8a69300a03dba1098
Cr-Commit-Position: refs/heads/master@{#292953}

Powered by Google App Engine
This is Rietveld 408576698