Issue 53153011: android bb: Stop passing --build-dir and --build-output-dir.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 53153011: android bb: Stop passing --build-dir and --build-output-dir. (Closed)

Created:
7 years, 1 month ago by Nico

Modified:
7 years, 1 month ago

Reviewers:
Isaac (away), Isaac (use chromium)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android bb: Stop passing --build-dir and --build-output-dir. These flags are ignored as of r232840 (extract_build.py), r232782 (zip_build.py), r232641ish (archive_layout_test_results.py). BUG=314253 TBR=ilevy@chromium.org (who lgtm'd as ilevy@google.com) landed in r232890

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	build/android/buildbot/bb_device_steps.py	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
	M	build/android/buildbot/bb_host_steps.py	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/53153011/50001

7 years, 1 month ago (2013-11-05 01:06:50 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34390

7 years, 1 month ago (2013-11-05 01:48:38 UTC) #4

Isaac (away)

7 years, 1 month ago (2013-11-05 11:27:38 UTC) #5

Message was sent while issue was closed.

Sorry Nico. Multilogin keeps switching me back to google acct. I should probably
give up and use multiprofile. 

Lgtm from correct account.

Expand Messages | Collapse Messages