Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5406)

Unified Diff: chrome/browser/resources/sync_internals/events.js

Issue 53153010: Introduce a button to toggle hiding/showing of the details in the events tab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: For committing. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/sync_internals/events.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/sync_internals/events.js
diff --git a/chrome/browser/resources/sync_internals/events.js b/chrome/browser/resources/sync_internals/events.js
index 0cda0860a6c521b6e6e31fc79c06bab09677f89f..e05510ba6c192179395601d33f4dc8119d1f6d8c 100644
--- a/chrome/browser/resources/sync_internals/events.js
+++ b/chrome/browser/resources/sync_internals/events.js
@@ -3,7 +3,17 @@
// found in the LICENSE file.
(function() {
-function makeLogEntryNode(entry) {
+'use strict';
+var toggleDisplay = function() {
+ var detailsNode = this.parentNode.getElementsByClassName('details')[0];
+ if (detailsNode.classList.contains('hidden')) {
+ detailsNode.classList.remove('hidden');
+ } else {
+ detailsNode.classList.add('hidden');
+ }
+}
+
+var makeLogEntryNode = function(entry) {
var timeNode = document.createElement('td');
timeNode.textContent = entry.date;
@@ -15,7 +25,14 @@ function makeLogEntryNode(entry) {
var details = document.createElement('pre');
details.textContent = JSON.stringify(entry.details, null, 2);
+ details.className = 'details';
+ details.classList.add('details');
+ details.classList.add('hidden');
+ var detailsToggleButton = document.createElement('button');
+ detailsToggleButton.addEventListener('click', toggleDisplay, false);
+ detailsToggleButton.textContent = 'Show/Hide Details';
var detailsNode = document.createElement('td');
+ detailsNode.appendChild(detailsToggleButton);
detailsNode.appendChild(details);
var node = document.createElement('tr');
@@ -27,7 +44,7 @@ function makeLogEntryNode(entry) {
return node;
}
-var syncEvents = document.getElementById('sync-events');
+var syncEvents = $('sync-events');
var entries = chrome.sync.log.entries;
for (var i = 0; i < entries.length; ++i) {
« no previous file with comments | « chrome/browser/resources/sync_internals/events.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698