Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 53153008: Remove webview-based behavior from --site-per-process flag. (Closed)

Created:
7 years, 1 month ago by Charlie Reis
Modified:
7 years, 1 month ago
Reviewers:
nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Remove webview-based behavior from --site-per-process flag. We're getting close to actually swapping RenderFrameHosts instead. BUG=99379, 314791 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232969

Patch Set 1 : Initial patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -103 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest_manager.cc View 4 chunks +31 lines, -49 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 chunk +1 line, -18 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Charlie Reis
Nasko, this undoes most of your old webview-based-OOP-iframe CL (https://chromiumcodereview.appspot.com/11772005/). As we land more of ...
7 years, 1 month ago (2013-11-04 21:44:51 UTC) #1
nasko
Yay! We are getting there! Totally happy about this code removal! LGTM
7 years, 1 month ago (2013-11-04 22:55:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/53153008/30001
7 years, 1 month ago (2013-11-04 23:34:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/53153008/30001
7 years, 1 month ago (2013-11-05 03:09:48 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-05 04:13:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/53153008/30001
7 years, 1 month ago (2013-11-05 06:49:09 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 13:56:01 UTC) #7
Message was sent while issue was closed.
Change committed as 232969

Powered by Google App Engine
This is Rietveld 408576698