Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 53153006: Simplify rate limiting since it's main thread shared context only (Closed)

Created:
7 years, 1 month ago by jamesr
Modified:
7 years, 1 month ago
Reviewers:
Stephen White, piman
CC:
chromium-reviews, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, senorblanco
Visibility:
Public.

Description

Simplify rate limiting since it's main thread shared context only This simplifies the compositor rate limiting code to only rate limit the shared main thread context, which as it happens is the only context that uses this feature at all. BUG=181120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232972

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -178 lines) Patch
M cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/texture_layer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
D cc/scheduler/rate_limiter.h View 1 chunk +0 lines, -61 lines 0 comments Download
D cc/scheduler/rate_limiter.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M cc/trees/layer_tree_host.h View 6 chunks +7 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 3 chunks +9 lines, -19 lines 0 comments Download
M cc/trees/layer_tree_host_client.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jamesr
The only thing that uses the rate limiting 'feature' is Canvas2DLayerBridge: https://code.google.com/p/chromium/codesearch#search/&q=setRateLimitContext&sq=package:chromium&type=cs which always uses ...
7 years, 1 month ago (2013-11-02 00:21:20 UTC) #1
jamesr
https://codereview.chromium.org/53153006/diff/1/cc/trees/layer_tree_host_client.h File cc/trees/layer_tree_host_client.h (right): https://codereview.chromium.org/53153006/diff/1/cc/trees/layer_tree_host_client.h#newcode47 cc/trees/layer_tree_host_client.h:47: // Blah blah blah bullshit Hmm, guess I have ...
7 years, 1 month ago (2013-11-02 00:31:32 UTC) #2
piman
lgtm https://codereview.chromium.org/53153006/diff/1/cc/trees/layer_tree_host_client.h File cc/trees/layer_tree_host_client.h (right): https://codereview.chromium.org/53153006/diff/1/cc/trees/layer_tree_host_client.h#newcode47 cc/trees/layer_tree_host_client.h:47: // Blah blah blah bullshit On 2013/11/02 00:31:32, ...
7 years, 1 month ago (2013-11-02 01:07:37 UTC) #3
Stephen White
This seems reasonable. I'm surprised that WebGL isn't doing rate limiting anymore, since swamping it ...
7 years, 1 month ago (2013-11-03 02:01:24 UTC) #4
Justin Novosad
Looks reasonable to me, but I wonder how CanvaProxy/WorkerCanvas/whatever is going to interact with this. ...
7 years, 1 month ago (2013-11-04 16:12:36 UTC) #5
Ken Russell (switch to Gerrit)
On 2013/11/03 02:01:24, Stephen White wrote: > This seems reasonable. I'm surprised that WebGL isn't ...
7 years, 1 month ago (2013-11-04 18:26:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/53153006/150001
7 years, 1 month ago (2013-11-04 20:29:08 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184423
7 years, 1 month ago (2013-11-05 00:42:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/53153006/150001
7 years, 1 month ago (2013-11-05 01:23:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/53153006/150001
7 years, 1 month ago (2013-11-05 03:09:21 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219361
7 years, 1 month ago (2013-11-05 05:32:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/53153006/150001
7 years, 1 month ago (2013-11-05 06:21:14 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 14:05:57 UTC) #13
Message was sent while issue was closed.
Change committed as 232972

Powered by Google App Engine
This is Rietveld 408576698