Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 531513003: Do not initialize an ApplicationManager in chromium. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not initialize an ApplicationManager in chromium. Chromium is only using a Service Provider, and not an Application. Moreover chromium should only depends on mojo_base.gyp, not mojo.gyp. R=darin@chromium.org,davemoore@chromium.org,blundel@chromium.org Committed: https://crrev.com/929c4844680bec5468bc4c1c2eeb304fa95c63dd Cr-Commit-Position: refs/heads/master@{#293525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M content/app/mojo/mojo_browsertest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/app/mojo/mojo_init.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/content_app.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
qsr
The documentation of mojo_base.gyp seem to imply that it should contain everything that chromium needs. ...
6 years, 3 months ago (2014-09-01 10:41:47 UTC) #2
blundell
lgtm
6 years, 3 months ago (2014-09-01 10:43:20 UTC) #3
qsr
Darin, Dave, any concerns with this?
6 years, 3 months ago (2014-09-03 08:09:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/531513003/1
6 years, 3 months ago (2014-09-04 08:04:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8632)
6 years, 3 months ago (2014-09-04 08:16:29 UTC) #8
qsr
darin@ -> Gentle ping? I need a LGTM from a content owner for this.
6 years, 3 months ago (2014-09-04 08:21:13 UTC) #9
darin (slow to review)
lgtm
6 years, 3 months ago (2014-09-05 14:02:54 UTC) #10
qsr
Thanks.
6 years, 3 months ago (2014-09-05 14:06:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/531513003/1
6 years, 3 months ago (2014-09-05 14:15:47 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6fdfbd4e0133131f242c6dc92714b97a809a74af
6 years, 3 months ago (2014-09-05 15:25:53 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:39:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/929c4844680bec5468bc4c1c2eeb304fa95c63dd
Cr-Commit-Position: refs/heads/master@{#293525}

Powered by Google App Engine
This is Rietveld 408576698