Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 531513002: Add cdbs to install-build-deps (Closed)

Created:
6 years, 3 months ago by kjellander_chromium
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add cdbs to install-build-deps The Common Debian Build System (cdbs) is needed for packaging .deb files in some configurations. http://packages.ubuntu.com/search?keywords=cdbs shows that it's available for all common Ubuntu distributions. On Precise and Trusty, the package is very small (~40kB), so it shouldn't have much impact on users. TESTED=ran install-build-deps.sh on Ubuntu Precise. R=friedman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/011f9c8ea361aab4ab654563ee53b650231630c3

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/install-build-deps.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
kjellander_chromium
6 years, 3 months ago (2014-09-01 08:16:40 UTC) #2
kjellander_chromium
friedman@: Can you provide us with guidance here. Is there any more information/motivation we need ...
6 years, 3 months ago (2014-09-02 20:04:12 UTC) #4
friedman
On 2014/09/02 20:04:12, kjellander wrote: > friedman@: Can you provide us with guidance here. Is ...
6 years, 3 months ago (2014-09-17 22:39:18 UTC) #5
kjellander_chromium
On 2014/09/17 22:39:18, friedman wrote: > On 2014/09/02 20:04:12, kjellander wrote: > > friedman@: Can ...
6 years, 3 months ago (2014-09-18 03:47:48 UTC) #6
friedman
lgtm
6 years, 3 months ago (2014-09-18 07:14:20 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/011f9c8ea361aab4ab654563ee53b650231630c3 Cr-Commit-Position: refs/heads/master@{#295674}
6 years, 3 months ago (2014-09-19 07:29:45 UTC) #8
kjellander_chromium
6 years, 3 months ago (2014-09-19 07:29:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 011f9c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698