Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 531403002: Move the warning banner of local disk shortage to the upper side. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 3 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move the warning banner of local disk shortage to the upper side. BUG=409731, 391703 TEST=manually Committed: https://crrev.com/cf3f67027c909fa1dbef79b38765152a86205872 Cr-Commit-Position: refs/heads/master@{#293086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/main.html View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
@yoshiki - could you take a look? Thanks!
6 years, 3 months ago (2014-09-03 03:49:42 UTC) #2
yoshiki
lgtm
6 years, 3 months ago (2014-09-03 05:15:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/531403002/1
6 years, 3 months ago (2014-09-03 05:43:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5b630b25b59621899e89c576cefc02205eaf52d2
6 years, 3 months ago (2014-09-03 06:40:57 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf3f67027c909fa1dbef79b38765152a86205872
Cr-Commit-Position: refs/heads/master@{#293086}

Powered by Google App Engine
This is Rietveld 408576698