Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: media/filters/skcanvas_video_renderer.h

Issue 531353002: Add VideoImageGenerator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/skcanvas_video_renderer.h
diff --git a/media/filters/skcanvas_video_renderer.h b/media/filters/skcanvas_video_renderer.h
index 3d1f4da56f76ef31b546b581bd1c85ca5ecdb2ee..f62d5e25a1d543645181665779a2fb0b9242c291 100644
--- a/media/filters/skcanvas_video_renderer.h
+++ b/media/filters/skcanvas_video_renderer.h
@@ -5,6 +5,7 @@
#ifndef MEDIA_FILTERS_SKCANVAS_VIDEO_RENDERER_H_
#define MEDIA_FILTERS_SKCANVAS_VIDEO_RENDERER_H_
+#include "base/memory/ref_counted.h"
#include "base/time/time.h"
#include "media/base/media_export.h"
#include "media/base/video_rotation.h"
@@ -29,7 +30,7 @@ class MEDIA_EXPORT SkCanvasVideoRenderer {
// specified by |dest_rect|.
//
// Black will be painted on |canvas| if |video_frame| is null.
- void Paint(media::VideoFrame* video_frame,
+ void Paint(const scoped_refptr<VideoFrame> video_frame,
scherkus (not reviewing) 2014/09/09 00:27:05 nit: missing a & to make these const-ref
rileya (GONE FROM CHROMIUM) 2014/09/09 00:50:14 Whoops, think I fixed all these now.
SkCanvas* canvas,
const gfx::RectF& dest_rect,
uint8 alpha,
@@ -37,7 +38,7 @@ class MEDIA_EXPORT SkCanvasVideoRenderer {
VideoRotation video_rotation);
// Copy |video_frame| on |canvas|.
- void Copy(media::VideoFrame* video_frame, SkCanvas* canvas);
+ void Copy(const scoped_refptr<VideoFrame>, SkCanvas* canvas);
scherkus (not reviewing) 2014/09/09 00:27:05 ditto
private:
// An RGB bitmap and corresponding timestamp of the previously converted

Powered by Google App Engine
This is Rietveld 408576698