Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 531313002: Changing the behavior of ReleaseSession() from Close() to Remove() (Closed)

Created:
6 years, 3 months ago by jrummell
Modified:
6 years, 3 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, eme-reviews_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

Merge 291602 "Changing the behavior of ReleaseSession() from Close() to Remove()" With the recent EME spec changes, ReleaseSession() got replaced by CloseSession() and RemoveSession(). Until all the changes to support both methods are in place, calls to ReleaseSession() should call RemoveSession() in order for existing prefixed EME applications to continue to work. Unprefixed Close() calls now call RemoveSession(), and thus don't do the correct thing. This will be fixed when both CloseSession() and RemoveSession() are passed through Pepper. BUG=406606 TEST=All EME browser_tests pass Review URL: https://codereview.chromium.org/497153005 Cr-Commit-Position: refs/heads/master@{#291602} (cherry picked from commit ec6d38eaaacd81198e1a78dec84418b54b218e55) R=xhwang@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/baa7b336638b4d8e85ad86ece54b80a13a5c819c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -29 lines) Patch
M media/cdm/ppapi/cdm_adapter.h View 1 chunk +5 lines, -4 lines 0 comments Download
M media/cdm/ppapi/cdm_adapter.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M media/cdm/ppapi/cdm_wrapper.h View 4 chunks +18 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jrummell
This was reviewed as https://codereview.chromium.org/497153005, just merging the change into M38.
6 years, 3 months ago (2014-09-02 23:53:23 UTC) #2
xhwang
I don't know what the new rule is for merge CLs, but drover used to ...
6 years, 3 months ago (2014-09-02 23:58:44 UTC) #3
jrummell
6 years, 3 months ago (2014-09-03 00:28:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as baa7b33 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698