Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 531253004: HPACK: Check pseudo-header order in decoder. (Closed)

Created:
6 years, 3 months ago by Bence
Modified:
6 years, 3 months ago
Reviewers:
Johnny
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

HPACK: Check pseudo-header order in decoder. Treat a header block with a pseudo-header field following a regular one as malformed, as required by HTTP/2 draft-14 Section 8.1.2.1. This lands server change 74067938 by bnc. BUG=400336 Committed: https://crrev.com/37f06e622f3122a0f456fa8017d832f7e08b7457 Cr-Commit-Position: refs/heads/master@{#293534}

Patch Set 1 #

Patch Set 2 : Update examples_07.hpack. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -5 lines) Patch
M net/data/spdy_tests/examples_07.hpack View 1 Binary file 0 comments Download
M net/spdy/hpack_decoder.h View 2 chunks +8 lines, -1 line 0 comments Download
M net/spdy/hpack_decoder.cc View 6 chunks +15 lines, -4 lines 0 comments Download
M net/spdy/hpack_decoder_test.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
PTAL
6 years, 3 months ago (2014-09-04 15:09:51 UTC) #2
Johnny
lgtm
6 years, 3 months ago (2014-09-04 16:14:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/531253004/20001
6 years, 3 months ago (2014-09-05 15:41:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3d6b56b2150705c369782c407ce0c7f54326de58
6 years, 3 months ago (2014-09-05 16:40:06 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:40:01 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37f06e622f3122a0f456fa8017d832f7e08b7457
Cr-Commit-Position: refs/heads/master@{#293534}

Powered by Google App Engine
This is Rietveld 408576698