bindings: Retires manual dispatching in createV8{HTML,SVG}Wrapper, etc.

Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "core/dom/Element.h"
 
+#include "bindings/core/v8/DOMDataStore.h"
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/ExceptionMessages.h"
 #include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/V8DOMWrapper.h"
+#include "bindings/core/v8/V8PerContextData.h"
 #include "core/CSSValueKeywords.h"
 #include "core/SVGNames.h"
 #include "core/XLinkNames.h"
 #include "core/XMLNames.h"
 #include "core/accessibility/AXObjectCache.h"
 #include "core/animation/AnimationTimeline.h"
 #include "core/animation/css/CSSAnimations.h"
 #include "core/css/CSSImageValue.h"
 #include "core/css/CSSStyleSheet.h"
 #include "core/css/CSSValuePool.h"
@@ skipping 3219 matching lines @@
 void Element::trace(Visitor* visitor)
 {
 #if ENABLE(OILPAN)
     if (hasRareData())
         visitor->trace(elementRareData());
     visitor->trace(m_elementData);
 #endif
     ContainerNode::trace(visitor);
 }
 
+v8::Handle<v8::Object> Element::wrap(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+{
+    if (isCustomElement())
+        return wrapCustomElement(creationContext, isolate);
+    return ContainerNode::wrap(creationContext, isolate);
+}
+
+v8::Handle<v8::Object> Element::wrapCustomElement(v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)

[haraken, 2014/09/04 02:17:46]

Why didn't you remove CustomElementWrapper in
bindings/core/v8/CustomElementWrapper.cpp when introducing
Element::wrapCustomElement?

[Yuki, 2014/09/04 04:47:29]

Just because I'd like to keep this CL small as much as possible.  We have a lot
of code to be removed in not only CustomElementWrapper but also
CustomElementConstructorBuilder, CustomElementBinding, etc.

Will remove (part of) them in separate CLs.

In a word, CustomeElementXxx need to manage prototype chain, but no need to
manage WrapperTypeInfo.

[haraken, 2014/09/04 04:54:52]

OK. Then can we create a helper method so that we don't need to duplicate the
code even if it will be removed in the near future? Since various developers are
modifying the code base, it is important to keep it as clean as possible.

[Yuki, 2014/09/04 14:10:14]

Okay, then, I've removed CustomElementWrapper.{h,cpp} in this CL.

+{
+    ASSERT(!DOMDataStore::containsWrapperNonTemplate(this, isolate));
+
+    ASSERT(!creationContext.IsEmpty());
+    v8::Handle<v8::Context> context = creationContext->CreationContext();
+
+    if (!isUpgradedCustomElement() || DOMWrapperWorld::world(context).isIsolatedWorld())
+        return ContainerNode::wrap(creationContext, isolate);
+
+    V8PerContextData* perContextData = V8PerContextData::from(context);
+    if (!perContextData)
+        return v8::Handle<v8::Object>();
+
+    CustomElementBinding* binding = perContextData->customElementBinding(customElementDefinition());
+    const WrapperTypeInfo* wrapperType = wrapperTypeInfo();
+    v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext, wrapperType, toInternalPointer(), isolate);
+    if (wrapper.IsEmpty())
+        return v8::Handle<v8::Object>();
+
+    wrapper->SetPrototype(binding->prototype());
+
+    wrapperType->refObject(toInternalPointer());
+    V8DOMWrapper::associateObjectWithWrapperNonTemplate(this, wrapperType, wrapper, isolate);
+    return wrapper;
+}
+
 } // namespace blink