Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 531183002: Add data-path restriction to tutorial, part 2. (Closed)

Created:
6 years, 3 months ago by jpmedley
Modified:
6 years, 3 months ago
Reviewers:
JF
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add data-path restriction to tutorial, part 2. BUG=none R= jf@chromium.org TEST=none NOTRY=true (documentation only change) Committed: https://crrev.com/445060e4e96898195590069cbb7b643439dc732e Cr-Commit-Position: refs/heads/master@{#293302}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Instructions for running a development server. #

Patch Set 3 : Add caption formatting to Chrome site. #

Patch Set 4 : Confirm upload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/common/extensions/docs/static/css/out/site.css View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/sass/_typography.scss View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
jpmedley
JF, The CL is related to this thread: https://groups.google.com/forum/#!msg/native-client-discuss/HBed4IvlOtI/BF4vhpPFrWIJ
6 years, 3 months ago (2014-09-02 20:49:31 UTC) #2
JF
https://codereview.chromium.org/531183002/diff/1/native_client_sdk/doc_generated/devguide/distributing.html File native_client_sdk/doc_generated/devguide/distributing.html (right): https://codereview.chromium.org/531183002/diff/1/native_client_sdk/doc_generated/devguide/distributing.html#newcode148 native_client_sdk/doc_generated/devguide/distributing.html:148: <th class="head"><p class="first last">Value</p> Is this an unrelated change? ...
6 years, 3 months ago (2014-09-02 20:57:34 UTC) #3
jpmedley
PTAL https://codereview.chromium.org/531183002/diff/1/native_client_sdk/doc_generated/devguide/distributing.html File native_client_sdk/doc_generated/devguide/distributing.html (right): https://codereview.chromium.org/531183002/diff/1/native_client_sdk/doc_generated/devguide/distributing.html#newcode148 native_client_sdk/doc_generated/devguide/distributing.html:148: <th class="head"><p class="first last">Value</p> I don't know. I'll ...
6 years, 3 months ago (2014-09-03 18:57:58 UTC) #4
JF
lgtm, thanks!
6 years, 3 months ago (2014-09-03 20:34:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmedley@chromium.org/531183002/20001
6 years, 3 months ago (2014-09-03 20:59:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8525)
6 years, 3 months ago (2014-09-04 00:37:02 UTC) #9
native-client-reviews_googlegroups.com
Oops! Forgot to tell it this was documentation only. I'm on it. Joe Medley | ...
6 years, 3 months ago (2014-09-04 15:17:16 UTC) #10
chromium-reviews
Oops! Forgot to tell it this was documentation only. I'm on it. Joe Medley | ...
6 years, 3 months ago (2014-09-04 15:17:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jmedley@chromium.org/531183002/20001
6 years, 3 months ago (2014-09-04 15:20:52 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 562043c2f17d22fc075cd3375cf5ed415b51c172
6 years, 3 months ago (2014-09-04 15:23:30 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:32 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/445060e4e96898195590069cbb7b643439dc732e
Cr-Commit-Position: refs/heads/master@{#293302}

Powered by Google App Engine
This is Rietveld 408576698