Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 531133002: Revert of Completed webkit radiusX, radiusY and rotationAngle handling. (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Completed webkit radiusX, radiusY and rotationAngle handling. (patchset #17 id:320001 of https://codereview.chromium.org/494833003/) Reason for revert: This causes Windows Debug dev builds to fail [3978->3/4014 ~33] CXX obj\content\browser\renderer_host\input\content.motion_event_web.obj FAILED: ninja -t msvc -e environment.x86 -- "d:\src\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\content\browser\renderer_host\input\content.motion_event_web.obj.rsp /c ..\..\content\browser\renderer_host\input\motion_event_web.cc /Foobj\content\browser\renderer_host\input\content.motion_event_web.obj /Fdobj\content\content.cc.pdb d:\src\cr3\src\content\browser\renderer_host\input\motion_event_web.cc(124) : error C2065: 'M_PI' : undeclared identifier d:\src\cr3\src\content\browser\renderer_host\input\motion_event_web.cc(125) : error C2065: 'M_PI_2' : undeclared identifier d:\src\cr3\src\content\browser\renderer_host\input\motion_event_web.cc(133) : error C2065: 'M_PI_2' : undeclared identifier I suspect this is due to precompiled headers; the math.h has already been included before _USE_MATH_DEFINES is defined in the .cc file. Original issue's description: > Make touch orientation attributes visible in Blink. > > Completed the path for touch orientation attributes (i.e. radiusX, radiusY and rotationAngle of a touch ellipse) from android to Blink. > > BUG=381394 > > Committed: https://chromium.googlesource.com/chromium/src/+/f7ff513cdeb881497d4977355a965c33b5fb7980 TBR=tdresser@chromium.org,darin@chromium.org,jdduke@chromium.org,mustaq@chromium.org NOTREECHECKS=true NOTRY=true BUG=381394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -391 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_android.h View 4 chunks +3 lines, -8 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_android.cc View 8 chunks +9 lines, -37 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_android_unittest.cc View 8 chunks +8 lines, -31 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_web.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_web.cc View 2 chunks +1 line, -30 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util.cc View 2 chunks +1 line, -40 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/events/gesture_detection/motion_event.h View 2 chunks +1 line, -9 lines 0 comments Download
M ui/events/gesture_detection/motion_event.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/motion_event_buffer.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M ui/events/gesture_detection/motion_event_buffer_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/motion_event_generic.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/events/gesture_detection/motion_event_generic.cc View 3 chunks +2 lines, -16 lines 0 comments Download
M ui/events/gestures/gesture_provider_aura_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/events/gestures/motion_event_aura.h View 2 chunks +1 line, -5 lines 0 comments Download
M ui/events/gestures/motion_event_aura.cc View 4 chunks +7 lines, -46 lines 0 comments Download
M ui/events/gestures/motion_event_aura_unittest.cc View 6 chunks +35 lines, -109 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
scottmg
Created Revert of Completed webkit radiusX, radiusY and rotationAngle handling.
6 years, 3 months ago (2014-09-02 18:53:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/531133002/1
6 years, 3 months ago (2014-09-02 18:56:03 UTC) #2
chromium-reviews
We have win_builder passing with my change: http://build.chromium.org/p/chromium.win/builders/Win%20Builder Any clue why the windows compilers/tests are ...
6 years, 3 months ago (2014-09-02 19:17:56 UTC) #3
scottmg
Yes, I filed a bug with the reason here: https://code.google.com/p/chromium/issues/detail?id=409940 On Tue, Sep 2, 2014 ...
6 years, 3 months ago (2014-09-02 19:20:01 UTC) #4
scottmg
Fix here: https://codereview.chromium.org/533863002/
6 years, 3 months ago (2014-09-02 19:45:40 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-02 19:46:07 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698