Add select instruction to Subzero bitcode reader.

src/PNaClTranslator.cpp

 //===- subzero/src/PNaClTranslator.cpp - ICE from bitcode -----------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the PNaCl bitcode file to Ice, to machine code
@@ skipping 1174 matching lines @@
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Illegal cast: " << Instruction::getOpcodeName(LLVMCastOp)
              << " " << *SrcType << " to " << *CastType;
       Error(StrBuf.str());
       return;
     }
     Ice::Variable *Dest = NextInstVar(Context->convertToIceType(CastType));
     Inst = Ice::InstCast::create(Func, CastKind, Dest, Src);
     break;
   }
+  case naclbitc::FUNC_CODE_INST_VSELECT: {
+    // VSELECT: [opval, opval, pred]
+    Ice::Operand *ThenVal = getOperand(convertRelativeToAbsIndex(Values[0]));
+    Ice::Type ThenType = ThenVal->getType();
+    Ice::Operand *ElseVal = getOperand(convertRelativeToAbsIndex(Values[1]));
+    Ice::Type ElseType = ElseVal->getType();
+    if (ThenType != ElseType) {
+      std::string Buffer;
+      raw_string_ostream StrBuf(Buffer);
+      StrBuf << "Select operands not same type. Found " << ThenType << " and "
+             << ElseType;
+      Error(StrBuf.str());
+      return;
+    }
+    Ice::Operand *CondVal = getOperand(convertRelativeToAbsIndex(Values[2]));
+    if (CondVal->getType() != Ice::IceType_i1) {

[Jim Stichnoth, 2014/09/02 19:38:49]

The predicate can also be a vector of i1 (and the test file should test this as
well).

[Karl, 2014/09/02 22:20:25]

Done.

+      std::string Buffer;
+      raw_string_ostream StrBuf(Buffer);
+      StrBuf << "Select condition not type i1. Found: " << CondVal->getType();
+      Error(StrBuf.str());
+      return;
+    }
+    Ice::Variable *DestVal = NextInstVar(ThenType);
+    Inst = Ice::InstSelect::create(Func, DestVal, CondVal, ThenVal, ElseVal);
+    break;
+  }
   case naclbitc::FUNC_CODE_INST_RET: {
     // RET: [opval?]
     InstIsTerminating = true;
     if (!isValidRecordSizeInRange(0, 1, "function block ret"))
       return;
     if (Values.size() == 0) {
       Inst = Ice::InstRet::create(Func);
     } else {
       Inst = Ice::InstRet::create(
           Func, getOperand(convertRelativeToAbsIndex(Values[0])));
@@ skipping 167 matching lines @@
   if (TopLevelBlocks != 1) {
     errs() << IRFilename
            << ": Contains more than one module. Found: " << TopLevelBlocks
            << "\n";
     ErrorStatus = true;
   }
   return;
 }
 
 } // end of namespace Ice