Add select instruction to Subzero bitcode reader.

Add select instruction to Subzero bitcode reader.

BUG=https: //code.google.com/p/nativeclient/issues/detail?id=3894
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1d6f0e4

[Karl, 2014-09-02 18:32:18]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2014-09-02 19:38:49]

https://codereview.chromium.org/531123002/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/531123002/diff/1/src/PNaClTranslator.cpp#newc...
src/PNaClTranslator.cpp:1210: if (CondVal->getType() != Ice::IceType_i1) {
The predicate can also be a vector of i1 (and the test file should test this as
well).

[Karl, 2014-09-02 22:20:25]

https://codereview.chromium.org/531123002/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/531123002/diff/1/src/PNaClTranslator.cpp#newc...
src/PNaClTranslator.cpp:1210: if (CondVal->getType() != Ice::IceType_i1) {
On 2014/09/02 19:38:49, stichnot wrote:
> The predicate can also be a vector of i1 (and the test file should test this
as
> well).

Done.

[Jim Stichnoth, 2014-09-02 22:34:01]

https://codereview.chromium.org/531123002/diff/20001/tests_lit/reader_tests/s...
File tests_lit/reader_tests/select.ll (right):

https://codereview.chromium.org/531123002/diff/20001/tests_lit/reader_tests/s...
tests_lit/reader_tests/select.ll:152: 
Single blank line (here and once below) for consistency?

https://codereview.chromium.org/531123002/diff/20001/tests_lit/reader_tests/s...
tests_lit/reader_tests/select.ll:177: define void @SelV4xfloatVcond(<4 x i1>
%pc, <4 x float> %pt, <4 x float> %pe) {
For completeness, include some missing combos:

(<16 x i1> %cond, <16 x i1> %arg1, <16 x i1> %arg2)
(<8 x i1> %cond, <8 x i16> %arg1, <8 x i16> %arg2)
(<8 x i1> %cond, <8 x i1> %arg1, <8 x i1> %arg2)
(<4 x i1> %cond, <4 x i1> %arg1, <4 x i1> %arg2)

See vector-select.ll.

[Karl, 2014-09-03 17:16:08]

https://codereview.chromium.org/531123002/diff/20001/tests_lit/reader_tests/s...
File tests_lit/reader_tests/select.ll (right):

https://codereview.chromium.org/531123002/diff/20001/tests_lit/reader_tests/s...
tests_lit/reader_tests/select.ll:152: 
On 2014/09/02 22:34:01, stichnot wrote:
> Single blank line (here and once below) for consistency?

Done.

https://codereview.chromium.org/531123002/diff/20001/tests_lit/reader_tests/s...
tests_lit/reader_tests/select.ll:177: define void @SelV4xfloatVcond(<4 x i1>
%pc, <4 x float> %pt, <4 x float> %pe) {
On 2014/09/02 22:34:01, stichnot wrote:
> For completeness, include some missing combos:
> 
> (<16 x i1> %cond, <16 x i1> %arg1, <16 x i1> %arg2)
> (<8 x i1> %cond, <8 x i16> %arg1, <8 x i16> %arg2)
> (<8 x i1> %cond, <8 x i1> %arg1, <8 x i1> %arg2)
> (<4 x i1> %cond, <4 x i1> %arg1, <4 x i1> %arg2)
> 
> See vector-select.ll.

Done.

[Jim Stichnoth, 2014-09-03 18:08:22]

Otherwise LGTM.

https://codereview.chromium.org/531123002/diff/20001/tests_lit/reader_tests/s...
File tests_lit/reader_tests/select.ll (right):

https://codereview.chromium.org/531123002/diff/20001/tests_lit/reader_tests/s...
tests_lit/reader_tests/select.ll:177: define void @SelV4xfloatVcond(<4 x i1>
%pc, <4 x float> %pt, <4 x float> %pe) {
On 2014/09/03 17:16:08, Karl wrote:
> On 2014/09/02 22:34:01, stichnot wrote:
> > For completeness, include some missing combos:
> > 
> > (<16 x i1> %cond, <16 x i1> %arg1, <16 x i1> %arg2)
> > (<8 x i1> %cond, <8 x i16> %arg1, <8 x i16> %arg2)
> > (<8 x i1> %cond, <8 x i1> %arg1, <8 x i1> %arg2)
> > (<4 x i1> %cond, <4 x i1> %arg1, <4 x i1> %arg2)
> > 
> > See vector-select.ll.
> 
> Done.

Still missing one:
(<8 x i1> %cond, <8 x i16> %arg1, <8 x i16> %arg2)

[jvoung (off chromium), 2014-09-03 18:20:36]

small nit too

https://codereview.chromium.org/531123002/diff/60001/tests_lit/reader_tests/s...
File tests_lit/reader_tests/select.ll (right):

https://codereview.chromium.org/531123002/diff/60001/tests_lit/reader_tests/s...
tests_lit/reader_tests/select.ll:1: ; Tests if we can read select instrutions.
instructions

[Karl, 2014-09-04 19:22:22]

Committed patchset #5 (id:80001) manually as 1d6f0e4 (tree was closed).

[Karl, 2014-09-04 19:23:07]

https://codereview.chromium.org/531123002/diff/60001/tests_lit/reader_tests/s...
File tests_lit/reader_tests/select.ll (right):

https://codereview.chromium.org/531123002/diff/60001/tests_lit/reader_tests/s...
tests_lit/reader_tests/select.ll:1: ; Tests if we can read select instrutions.
On 2014/09/03 18:20:35, jvoung wrote:
> instructions

Done.