Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 53111: Treat all 1xx the same as a 100 (continue). (Closed)

Created:
11 years, 9 months ago by eroman
Modified:
9 years, 6 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Treat all 1xx the same as a 100 (continue). BUG=8440 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12634

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move Ignores1xx to appear AFTER Ignores100, and add a comment on how it differs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M net/http/http_network_transaction.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
11 years, 9 months ago (2009-03-26 20:16:21 UTC) #1
wtc
LGTM. http://codereview.chromium.org/53111/diff/1/3 File net/http/http_network_transaction_unittest.cc (right): http://codereview.chromium.org/53111/diff/1/3#newcode558 Line 558: TEST_F(HttpNetworkTransactionTest, Ignores1xx) { You may want to ...
11 years, 9 months ago (2009-03-26 21:00:40 UTC) #2
eroman
http://codereview.chromium.org/53111/diff/1/3 File net/http/http_network_transaction_unittest.cc (right): http://codereview.chromium.org/53111/diff/1/3#newcode558 Line 558: TEST_F(HttpNetworkTransactionTest, Ignores1xx) { On 2009/03/26 21:00:40, wtc wrote: ...
11 years, 9 months ago (2009-03-26 21:07:25 UTC) #3
eroman
11 years, 9 months ago (2009-03-26 21:24:44 UTC) #4
http://codereview.chromium.org/53111/diff/1/3
File net/http/http_network_transaction_unittest.cc (right):

http://codereview.chromium.org/53111/diff/1/3#newcode558
Line 558: TEST_F(HttpNetworkTransactionTest, Ignores1xx) {
On 2009/03/26 21:00:40, wtc wrote:
> You may want to point out how this unit test differs from
> the next (Ignores100).  I believe the only difference is
> the response status line ("102 Unspecified status code" vs.
> "100 Continue".

Done.

Also moved this to appear below the Ignores100 test.

Powered by Google App Engine
This is Rietveld 408576698