Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 531093002: Lower simplified StringLessThan[OrEqual] to runtime call. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Lower simplified StringLessThan[OrEqual] to runtime call. R=titzer@chromium.org TEST=cctest/test-simplified-lowering/LowerStringOps_to_call_and_compare Committed: https://code.google.com/p/v8/source/detail?r=23653

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed comments by Ben Titzer. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -23 lines) Patch
M src/compiler/machine-operator.h View 1 3 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 2 chunks +33 lines, -14 lines 0 comments Download
M test/cctest/cctest.status View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-02 16:57:22 UTC) #1
titzer
lgtm with comment https://codereview.chromium.org/531093002/diff/1/test/cctest/compiler/test-simplified-lowering.cc File test/cctest/compiler/test-simplified-lowering.cc (right): https://codereview.chromium.org/531093002/diff/1/test/cctest/compiler/test-simplified-lowering.cc#newcode1059 test/cctest/compiler/test-simplified-lowering.cc:1059: t.machine()->is32() ? t.machine()->Int32LessThan()->opcode() Maybe we should ...
6 years, 3 months ago (2014-09-03 11:36:53 UTC) #2
Michael Starzinger
https://codereview.chromium.org/531093002/diff/1/test/cctest/compiler/test-simplified-lowering.cc File test/cctest/compiler/test-simplified-lowering.cc (right): https://codereview.chromium.org/531093002/diff/1/test/cctest/compiler/test-simplified-lowering.cc#newcode1054 test/cctest/compiler/test-simplified-lowering.cc:1054: TEST(LowerStringOps_to_call_and_compare) { Note to self: Adapt status file when ...
6 years, 3 months ago (2014-09-03 12:04:50 UTC) #3
Michael Starzinger
6 years, 3 months ago (2014-09-03 12:43:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 23653 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698