Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 531003002: Cleanup in base/test/launcher: move more code to anonymous namespace (Closed)

Created:
6 years, 3 months ago by Paweł Hajdan Jr.
Modified:
6 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup in base/test/launcher: move more code to anonymous namespace BUG=none R=machenbach@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/dfd9d11192beffb30a100d568b94f0718bd6fe53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -141 lines) Patch
M base/test/launcher/test_launcher.h View 1 chunk +0 lines, -5 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 3 chunks +131 lines, -136 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paweł Hajdan Jr.
No code changes, just a move.
6 years, 3 months ago (2014-09-02 12:35:20 UTC) #2
Michael Achenbach
lgtm
6 years, 3 months ago (2014-09-02 12:42:44 UTC) #3
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as dfd9d11 (presubmit successful).
6 years, 3 months ago (2014-09-03 10:06:03 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:47 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfd9d11192beffb30a100d568b94f0718bd6fe53
Cr-Commit-Position: refs/heads/master@{#293108}

Powered by Google App Engine
This is Rietveld 408576698